linux-kernel - Re: [PATCH] watchdog: LENOVO_SE10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 07 May 2024 06:59:57 -0400
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Geert Uytterhoeven" <geert+renesas@...der.be>,
 "David Ober" <dober@...ovo.com>, "Wim Van Sebroeck" <wim@...ux-watchdog.org>,
 "Guenter Roeck" <linux@...ck-us.net>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: LENOVO_SE10_WDT should depend on X86 && DMI

Thanks Geert,

On Tue, May 7, 2024, at 6:07 AM, Geert Uytterhoeven wrote:
> The Lenovo SE10 watchdog is only present on Lenovo ThinkEdge SE10
> platforms, which are based on Intel Atom SoCs, and its driver relies on
> DMI tables.  Hence add dependencies on X86 && DMI, to prevent asking the
> user about this driver when configuring a kernel without Intel Atom or
> DMI support.
>
> While at it, fix the odd indentation (spaces instead of TABs).
>
> Fixes: 1f6602c8ed1eccac ("watchdog: lenovo_se10_wdt: Watchdog driver 
> for Lenovo SE10 platform")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/watchdog/Kconfig | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 24dfecbb30157fff..f002e9627c076f1f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -255,14 +255,15 @@ config GPIO_WATCHDOG_ARCH_INITCALL
>  	  If in doubt, say N.
> 
>  config LENOVO_SE10_WDT
> -        tristate "Lenovo SE10 Watchdog"
> -        select WATCHDOG_CORE
> -        help
> -          If you say yes here you get support for the watchdog
> -          functionality for the Lenovo SE10 platform.
> -
> -          This driver can also be built as a module. If so, the module
> -          will be called lenovo-se10-wdt.
> +	tristate "Lenovo SE10 Watchdog"
> +	depends on (X86 && DMI) || COMPILE_TEST
> +	select WATCHDOG_CORE
> +	help
> +	  If you say yes here you get support for the watchdog
> +	  functionality for the Lenovo SE10 platform.
> +
> +	  This driver can also be built as a module. If so, the module
> +	  will be called lenovo-se10-wdt.
> 
>  config MENF21BMC_WATCHDOG
>  	tristate "MEN 14F021P00 BMC Watchdog"
> -- 
> 2.34.1

Looks good to me. And apologies on the spaces being wrong in the first place.
Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>

Mark