linux-kernel - Re: [PATCH] usb: dwc3: gadget: create per ep interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202405071800.omy5Ou1D-lkp@intel.com>
Date: Tue, 7 May 2024 19:08:33 +0800
From: kernel test robot <lkp@...el.com>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	michael.riesch@...fvision.net, kernel@...gutronix.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michael Grzeschik <m.grzeschik@...gutronix.de>
Subject: Re: [PATCH] usb: dwc3: gadget: create per ep interrupts

Hi Michael,

kernel test robot noticed the following build warnings:

[auto build test WARNING on dd5a440a31fae6e459c0d6271dddd62825505361]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Grzeschik/usb-dwc3-gadget-create-per-ep-interrupts/20240507-070804
base:   dd5a440a31fae6e459c0d6271dddd62825505361
patch link:    https://lore.kernel.org/r/20240507-dwc3_per_ep_irqthread-v1-1-f14dec6de19f%40pengutronix.de
patch subject: [PATCH] usb: dwc3: gadget: create per ep interrupts
config: x86_64-buildonly-randconfig-001-20240507 (https://download.01.org/0day-ci/archive/20240507/202405071800.omy5Ou1D-lkp@intel.com/config)
compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240507/202405071800.omy5Ou1D-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405071800.omy5Ou1D-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc3/gadget.c:1068:6: warning: variable 'count_processed' set but not used [-Wunused-but-set-variable]
    1068 |         int count_processed = 0;
         |             ^
   1 warning generated.


vim +/count_processed +1068 drivers/usb/dwc3/gadget.c

  1059	
  1060	static void dwc3_process_event_entry(struct dwc3 *dwc,
  1061					     const union dwc3_event *event);
  1062	
  1063	static irqreturn_t dwc3_endpoint_thread_irq(int irq, void *_dep)
  1064	{
  1065		struct dwc3_ep *dep = _dep;
  1066		struct dwc3 *dwc = dep->dwc;
  1067		const union dwc3_event *event;
> 1068		int count_processed = 0;
  1069		u32 event_raw;
  1070		unsigned long flags;
  1071	
  1072		dep->givebacks_current_turn = 0;
  1073	
  1074		spin_lock_irqsave(&dep->event_lock, flags);
  1075	
  1076		if (dep->ep_event_flags & DWC3_EP_EVENT_OVERFLOW) {
  1077			dev_err(dwc->dev, "ep%d: event buffer overflow\n", dep->number);
  1078			dep->ep_event_flags &= ~DWC3_EP_EVENT_OVERFLOW;
  1079		}
  1080	
  1081		while (dep->ep_event_r_index != dep->ep_event_w_index) {
  1082	
  1083			event_raw = dep->ep_event_buffer[dep->ep_event_r_index];
  1084	
  1085			/*
  1086			 * we have a copy of the event, so we can release the lock
  1087			 */
  1088			spin_unlock_irqrestore(&dep->event_lock, flags);
  1089	
  1090			event = (const union dwc3_event *) &event_raw;
  1091	
  1092			spin_lock(&dwc->lock);
  1093			dwc3_process_event_entry(dwc, event);
  1094			spin_unlock(&dwc->lock);
  1095	
  1096			/*
  1097			 * we need to re-acquire the lock to update the read index
  1098			 */
  1099			spin_lock_irqsave(&dep->event_lock, flags);
  1100	
  1101			dep->ep_event_r_index = (dep->ep_event_r_index + 1) %
  1102						 ARRAY_SIZE(dep->ep_event_buffer);
  1103	
  1104			count_processed += 1;
  1105		}
  1106	
  1107		spin_unlock_irqrestore(&dep->event_lock, flags);
  1108	
  1109		return IRQ_HANDLED;
  1110	}
  1111	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki