linux-kernel - Re: [PATCH v3 1/4] x86/pkeys: Signal handling function interface changes to accept PKRU as a parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734qtrf5j.ffs@tglx>
Date: Tue, 07 May 2024 14:16:08 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>,
 linux-kernel@...r.kernel.org
Cc: x86@...nel.org, dave.hansen@...ux.intel.com, mingo@...nel.org,
 keith.lucas@...cle.com, aruna.ramakrishna@...cle.com
Subject: Re: [PATCH v3 1/4] x86/pkeys: Signal handling function interface
 changes to accept PKRU as a parameter

On Thu, Apr 25 2024 at 18:05, Aruna Ramakrishna wrote:
>  
> -extern bool copy_fpstate_to_sigframe(void __user *buf, void __user *fp, int size);
> +extern bool copy_fpstate_to_sigframe(void __user *buf, void __user *fp, int size,
> +				     u32 pkru);

No line break required. Line length is 100 characters. All over the place.
 
> @@ -229,6 +230,7 @@ handle_signal(struct ksignal *ksig, struct pt_regs *regs)
>  {
>  	bool stepping, failed;
>  	struct fpu *fpu = &current->thread.fpu;
> +	u32 pkru = read_pkru();

Please use reverse fir tree ordering of variables:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations
  
Thanks,

        tglx