linux-kernel - Re: [PATCH v4 1/3] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cypxeprv.wl-tiwai@suse.de>
Date: Tue, 07 May 2024 15:05:08 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Baojun Xu <baojun.xu@...com>,
	robh+dt@...nel.org,
	lgirdwood@...il.com,
	perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com,
	kevin-lu@...com,
	shenghao-ding@...com,
	navada@...com,
	13916275206@....com,
	v-po@...com,
	niranjan.hy@...com,
	alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com,
	yung-chuan.liao@...ux.intel.com,
	broonie@...nel.org,
	soyer@....hu
Subject: Re: [PATCH v4 1/3] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI

On Tue, 30 Apr 2024 15:45:28 +0200,
Andy Shevchenko wrote:
> 
> On Tue, Apr 30, 2024 at 02:58:10PM +0200, Takashi Iwai wrote:
> > On Tue, 30 Apr 2024 09:25:42 +0200, Baojun Xu wrote:
> 
> ...
> 
> > >  snd-hda-cs-dsp-ctls-objs :=		hda_cs_dsp_ctl.o
> > >  snd-hda-scodec-component-objs :=	hda_component.o
> > >  snd-hda-scodec-tas2781-i2c-objs :=	tas2781_hda_i2c.o
> > > +snd-hda-scodec-tas2781-spi-y :=	tas2781_hda_spi.o tas2781_spi_fwlib.o
> > 
> > A nitpicking: better to align with other lines (i.e. with *-objs
> > instead of *-y).
> 
> I object this. The better approach is to have a precursor patch that switches
> to y over objs (the latter is for user space code / tools).

Indeed it can be a good cleanup, yeah.  Let me try.


thanks,

Takashi