linux-kernel - Re: [PATCH v1 1/1] lockd: Use *-y instead of *-objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjuijMla78l+sl5S@tissot.1015granger.net>
Date: Wed, 8 May 2024 12:04:28 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>, Jeff Layton <jlayton@...nel.org>,
        Neil Brown <neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>,
        Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>
Subject: Re: [PATCH v1 1/1] lockd: Use *-y instead of *-objs in Makefile

On Wed, May 08, 2024 at 06:19:38PM +0300, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> 
> Note, the original approach is weirdest from the existing.
> Only a few drivers use this (-objs-y) one most likely by mistake.
> 
>  fs/lockd/Makefile | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/lockd/Makefile b/fs/lockd/Makefile
> index ac9f9d84510e..fe3e23dd29c3 100644
> --- a/fs/lockd/Makefile
> +++ b/fs/lockd/Makefile
> @@ -7,8 +7,7 @@ ccflags-y += -I$(src)			# needed for trace events
>  
>  obj-$(CONFIG_LOCKD) += lockd.o
>  
> -lockd-objs-y += clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
> -	        svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
> -lockd-objs-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
> -lockd-objs-$(CONFIG_PROC_FS) += procfs.o
> -lockd-objs		      := $(lockd-objs-y)
> +lockd-y := clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
> +	   svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
> +lockd-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
> +lockd-$(CONFIG_PROC_FS) += procfs.o
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 

Acked-by: Chuck Lever <chuck.lever@...cle.com>

Unless, of course, you'd like me to take this through the nfsd tree.

-- 
Chuck Lever