linux-kernel - Re: [PATCH v2 2/5] selftests/sgx: Include KHDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 08 May 2024 19:44:40 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Dave Hansen" <dave.hansen@...el.com>, "Edward Liaw"
 <edliaw@...gle.com>, <shuah@...nel.org>, "Mark Brown" <broonie@...nel.org>,
 "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
 "Catalin Marinas" <catalin.marinas@....com>, "Will Deacon"
 <will@...nel.org>, "Nhat Pham" <nphamcs@...il.com>, "Johannes Weiner"
 <hannes@...xchg.org>, "Christian Brauner" <brauner@...nel.org>, "Eric
 Biederman" <ebiederm@...ssion.com>, "Kees Cook" <keescook@...omium.org>,
 "OGAWA Hirofumi" <hirofumi@...l.parknet.co.jp>, "Thomas Gleixner"
 <tglx@...utronix.de>, "Ingo Molnar" <mingo@...hat.com>, "Peter Zijlstra"
 <peterz@...radead.org>, "Darren Hart" <dvhart@...radead.org>, "Davidlohr
 Bueso" <dave@...olabs.net>, André Almeida
 <andrealmeid@...lia.com>, "Jiri Kosina" <jikos@...nel.org>, "Benjamin
 Tissoires" <bentiss@...nel.org>, "Jason Gunthorpe" <jgg@...pe.ca>, "Kevin
 Tian" <kevin.tian@...el.com>, "Andy Lutomirski" <luto@...capital.net>,
 "Will Drewry" <wad@...omium.org>, "Marc Zyngier" <maz@...nel.org>, "Oliver
 Upton" <oliver.upton@...ux.dev>, "James Morse" <james.morse@....com>,
 "Suzuki K Poulose" <suzuki.poulose@....com>, "Zenghui Yu"
 <yuzenghui@...wei.com>, "Paolo Bonzini" <pbonzini@...hat.com>, "Sean
 Christopherson" <seanjc@...gle.com>, "Anup Patel" <anup@...infault.org>,
 "Atish Patra" <atishp@...shpatra.org>, "Paul Walmsley"
 <paul.walmsley@...ive.com>, "Palmer Dabbelt" <palmer@...belt.com>, "Albert
 Ou" <aou@...s.berkeley.edu>, "Christian Borntraeger"
 <borntraeger@...ux.ibm.com>, "Janosch Frank" <frankja@...ux.ibm.com>,
 "Claudio Imbrenda" <imbrenda@...ux.ibm.com>, "David Hildenbrand"
 <david@...hat.com>, Mickaël Salaün <mic@...ikod.net>,
 "Paul Moore" <paul@...l-moore.com>, "James Morris" <jmorris@...ei.org>,
 "Serge E. Hallyn" <serge@...lyn.com>, "Andrew Morton"
 <akpm@...ux-foundation.org>, "Seth Forshee" <sforshee@...nel.org>, "Bongsu
 Jeon" <bongsu.jeon@...sung.com>, "David S. Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, "Steffen Klassert"
 <steffen.klassert@...unet.com>, "Herbert Xu" <herbert@...dor.apana.org.au>,
 Andreas Färber <afaerber@...e.de>, "Manivannan Sadhasivam"
 <manivannan.sadhasivam@...aro.org>, "Matthieu Baerts" <matttbe@...nel.org>,
 "Mat Martineau" <martineau@...nel.org>, "Geliang Tang"
 <geliang@...nel.org>, "Willem de Bruijn" <willemdebruijn.kernel@...il.com>,
 "Fenghua Yu" <fenghua.yu@...el.com>, "Reinette Chatre"
 <reinette.chatre@...el.com>, "Mathieu Desnoyers"
 <mathieu.desnoyers@...icios.com>, "Paul E. McKenney" <paulmck@...nel.org>,
 "Boqun Feng" <boqun.feng@...il.com>, "Alexandre Belloni"
 <alexandre.belloni@...tlin.com>, "Muhammad Usama Anjum"
 <usama.anjum@...labora.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
 <kernel-team@...roid.com>, <linux-sound@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-mm@...ck.org>,
 <linux-input@...r.kernel.org>, <iommu@...ts.linux.dev>,
 <kvmarm@...ts.linux.dev>, <kvm@...r.kernel.org>,
 <kvm-riscv@...ts.infradead.org>, <linux-riscv@...ts.infradead.org>,
 <linux-security-module@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
 <netdev@...r.kernel.org>, <linux-actions@...ts.infradead.org>,
 <mptcp@...ts.linux.dev>, <linux-rtc@...r.kernel.org>,
 <linux-sgx@...r.kernel.org>, <bpf@...r.kernel.org>, "kernel test robot"
 <oliver.sang@...el.com>
Subject: Re: [PATCH v2 2/5] selftests/sgx: Include KHDR_INCLUDES in Makefile

On Wed May 8, 2024 at 6:33 PM EEST, Dave Hansen wrote:
> On 5/7/24 14:38, Edward Liaw wrote:
> > Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness
> > dependencies (-D_GNU_SOURCE).
> > 
> > Also, remove redefinitions of _GNU_SOURCE in the source code.
>
> From an x86 and SGX perspective, looks fine.  I assume Shuah is planning
> on taking this pile.
>
> Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>

Yep,

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

I also quickly tested with NUC7 for what it is worth:

Tested-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko