linux-kernel - Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4d66d0b-ac3a-416b-ad47-3869e84a03fd@nvidia.com>
Date: Wed, 8 May 2024 10:29:53 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Reinette Chatre <reinette.chatre@...el.com>
Cc: Shuah Khan <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Fenghua Yu <fenghua.yu@...el.com>, Valentin Obst <kernel@...entinobst.de>,
 linux-kselftest@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 llvm@...ts.linux.dev
Subject: Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to
 abs(), labs() calls

On 5/8/24 1:00 AM, Ilpo Järvinen wrote:
> On Tue, 7 May 2024, Reinette Chatre wrote:
> 
>> Hi John,
>>
>> On 5/7/2024 6:25 PM, John Hubbard wrote:
>>> On 5/7/24 6:21 PM, Reinette Chatre wrote:
>>>> Hi John,
>>> ...
> Yes, there are two *abs() calls in this function.
> 
> In this case is okay to remove the first one since it didn't remove
> absolute value completely, whereas in the MBA/MBM cases v1 removed *abs()
> call entirely which was wrong thing to do.
> 
> I explicitly noted in my v1 comment that this CMT change is okay but the
> other two were not.
> 

Got it, thanks Ilpo (and Reinette), I'll send a v3 with it fixed up
accordingly, appreciate your patience here. :)


thanks,
-- 
John Hubbard
NVIDIA