linux-kernel - Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0ce1a9b-d63d-43e7-96f0-6eeb35051f63@broadcom.com>
Date: Wed, 8 May 2024 10:39:55 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-kernel@...r.kernel.org
Cc: Tal Gilboa <talgi@...dia.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

On 5/8/24 07:29, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>

> ---
> 
> Reported by Olek. As I said him this is correct change which is
> documented in Documentation/kbuild/makefiles.rst "Composite Host
> Programs" (mind the meaning of the word "host"!).

Why not credit him with an official Reported-by?

> 
>   lib/dim/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index c4cc4026c451..5b9bfaac7ac1 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -4,4 +4,4 @@
>   
>   obj-$(CONFIG_DIMLIB) += dimlib.o
>   
> -dimlib-objs := dim.o net_dim.o rdma_dim.o
> +dimlib-y := dim.o net_dim.o rdma_dim.o

-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)