linux-kernel - Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zju-HVbo0lMsR6Ee@smile.fi.intel.com>
Date: Wed, 8 May 2024 21:02:05 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
	"Lobakin, Aleksander" <aleksander.lobakin@...el.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Richard Cochran <richardcochran@...il.com>,
	John Fastabend <john.fastabend@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	Jakub Kicinski <kuba@...nel.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y
 instead of *-objs in Makefile

On Wed, May 08, 2024 at 10:58:37AM -0700, Jacob Keller wrote:
> On 5/8/2024 7:42 AM, Loktionov, Aleksandr wrote:
> >> From: Alexander Lobakin <aleksander.lobakin@...el.com>
> >> Date: Wed, 8 May 2024 16:39:21 +0200
> >>> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >>> Date: Wed, 8 May 2024 17:25:31 +0300
> >>>> On Wed, May 08, 2024 at 03:35:26PM +0200, Alexander Lobakin
> >> wrote:
> >>>>>> *-objs suffix is reserved rather for (user-space) host
> >> programs
> >>>>>> while usually *-y suffix is used for kernel drivers (although
> >>>>>> *-objs works for that purpose for now).
> >>>>>>
> >>>>>> Let's correct the old usages of *-objs in Makefiles.
> >>>>>
> >>>>> Wait, I was sure I've seen somewhere that -objs is more new and
> >>>>> preferred over -y.
> >>>>
> >>>> Then you are mistaken.
> >>>>
> >>>>> See recent dimlib comment where Florian changed -y to -objs for
> >>>>> example.
> >>>>
> >>>> So does he :-)
> >>>>
> >>>>> Any documentation reference that -objs is for userspace and we
> >>>>> should clearly use -y?
> >>>>
> >>>> Sure. Luckily it's documented in
> >> Documentation/kbuild/makefiles.rst
> >>>> "Composite Host Programs" (mind the meaning of the word
> >> "host"!).
> >>>
> >>> Oh okay, I see. `-objs` is indeed only mentioned in the host
> >> chapter.
> >>
> >> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> >>
> >> Thanks,
> >> Olek
> > 
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> 
> Yea, reading the makefiles.rst again, it does seem that -objs only is
> intended for host programs. The fact that it works now is an accident.
> Further use of -y is necessary as we also use module-$(CONFIG_SYMBOL) to
> resolve cases where we only include the files if the configuration is set.
> 
> Makes sense to clean this up.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Oops, just sent a v2 to address LKP findings. Can you look at it instead?

-- 
With Best Regards,
Andy Shevchenko