linux-kernel - Re: [PATCH net-next v2 1/1] net: intel: Use *-y instead of *-objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f2eb3d5-649d-4723-af89-ca625070877d@intel.com>
Date: Wed, 8 May 2024 11:23:39 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
CC: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Alexander Lobakin <aleksander.lobakin@...el.com>,
	Richard Cochran <richardcochran@...il.com>, Alexei Starovoitov
	<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, "Jesper Dangaard
 Brouer" <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH net-next v2 1/1] net: intel: Use *-y instead of *-objs in
 Makefile



On 5/8/2024 11:00 AM, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

FWIW I applied v1 and v2, and got only the following range-diff:

> $ git range-diff net-next/main use-module-y-v1 use-module-y-v2
> 1:  0e5c43eb8e36 ! 1:  2cf60c46b7a8 net: intel: Use *-y instead of *-objs in Makefile
>     @@ Commit message
> 
>          Let's correct the old usages of *-objs in Makefiles.
> 
>     -    Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>     -    Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
>          Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>     -    Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>     +    Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
>     +    Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
>       ## drivers/net/ethernet/intel/e1000/Makefile ##
>      @@
>     @@ drivers/net/ethernet/intel/igbvf/Makefile
> 
>       ## drivers/net/ethernet/intel/igc/Makefile ##
>      @@
>     + #
>     +
>       obj-$(CONFIG_IGC) += igc.o
>     - igc-$(CONFIG_IGC_LEDS) += igc_leds.o
>     +-igc-$(CONFIG_IGC_LEDS) += igc_leds.o
> 
>      -igc-objs := igc_main.o igc_mac.o igc_i225.o igc_base.o igc_nvm.o igc_phy.o \
>      -igc_diag.o igc_ethtool.o igc_ptp.o igc_dump.o igc_tsn.o igc_xdp.o
>      +igc-y := igc_main.o igc_mac.o igc_i225.o igc_base.o igc_nvm.o igc_phy.o \
>      +   igc_diag.o igc_ethtool.o igc_ptp.o igc_dump.o igc_tsn.o igc_xdp.o
>     ++igc-$(CONFIG_IGC_LEDS) += igc_leds.o
> 
>       ## drivers/net/ethernet/intel/ixgbe/Makefile ##
>      @@
> 

This matches the changes described w.r.t ordering, and everything built
properly when I tested it on my test kernel tree.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>