linux-kernel - Re: [PATCH 1/5] regulator: dt-bindings: Unify compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 8 May 2024 08:02:35 +0530
From: Neha Malcom Francis <n-francis@...com>
To: Rob Herring <robh@...nel.org>
CC: <conor+dt@...nel.org>, <krzk+dt@...nel.org>, <kristo@...nel.org>,
        <vigneshr@...com>, <nm@...com>, <broonie@...nel.org>,
        <lgirdwood@...il.com>, <marten.lindahl@...s.com>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <u-kumar1@...com>
Subject: Re: [PATCH 1/5] regulator: dt-bindings: Unify compatible

Hi Rob

On 08/05/24 02:41, Rob Herring wrote:
> On Tue, May 07, 2024 at 05:51:54PM +0530, Neha Malcom Francis wrote:
>> TPS62870/1/2/3 devices have different output currents (6A/9A/12A/15A) of
>> the TPS6287x family. The I2C addresses are the same between them. There
>> is no need for different compatibles for each for these devices so drop
>> them and add a unified "ti,tps6287x" compatible.
> 
> And s/w will never need to know what the max output current is?
> 

Not really, as per understanding from the hardware teams.

> Same i2c address has no bearing. That's usually not even fixed for 1
> device.
> 
>>
>> Signed-off-by: Neha Malcom Francis <n-francis@...com>
>> ---
>>   .../devicetree/bindings/regulator/ti,tps62870.yaml         | 7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>> index 386989544dac..2998773db990 100644
>> --- a/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62870.yaml
>> @@ -15,10 +15,7 @@ allOf:
>>   properties:
>>     compatible:
>>       enum:
>> -      - ti,tps62870
>> -      - ti,tps62871
>> -      - ti,tps62872
>> -      - ti,tps62873
>> +      - ti,tps6287x
> 
> You just broke the existing users.
> 
> Wildcards in compatible names are generally discouraged. Maybe if this
> was a new binding and had sufficient justification why we don't need to
> distinguish parts, but this is an ABI and we're stuck with them.
> 
> If you are doing this to support more versions, then feel free to use
> an existing string. It's just a unique identifier. You have 4 to choose
> from.

Thanks for the review, Rob! I should have known better than to remove 
compatibles, excuse the noise!

> 
> Rob
> 

-- 
Thanking You
Neha Malcom Francis