[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240508194308.48366-1-mario.limonciello@amd.com>
Date: Wed, 8 May 2024 14:43:07 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: <dri-devel@...ts.freedesktop.org>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
CC: <linux-kernel@...r.kernel.org>, <amd-gfx@...ts.freedesktop.org>,
"Aurabindo Pillai" <aurabindo.pillai@....com>, Daniel Wheeler
<daniel.wheeler@....com>, Fangzhi Zuo <jerry.zuo@....com>, Mario Limonciello
<mario.limonciello@....com>, Tyler Schneider <tyler.schneider@....com>
Subject: [PATCH 1/2] drm: Allow mode object properties to be added after a device is registered
When the colorspace property is registered on MST devices there is
no `obj_free_cb` callback for it in drm_mode_object_add().
Don't show a warning trace for __drm_mode_object_add() calls for
DRM_MODE_OBJECT_PROPERTY.
Reported-and-tested-by: Tyler Schneider <tyler.schneider@....com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3353
Signed-off-by: Mario Limonciello <mario.limonciello@....com>
---
drivers/gpu/drm/drm_mode_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mode_object.c b/drivers/gpu/drm/drm_mode_object.c
index 0e8355063eee..b077547a2db4 100644
--- a/drivers/gpu/drm/drm_mode_object.c
+++ b/drivers/gpu/drm/drm_mode_object.c
@@ -42,7 +42,7 @@ int __drm_mode_object_add(struct drm_device *dev, struct drm_mode_object *obj,
{
int ret;
- WARN_ON(!dev->driver->load && dev->registered && !obj_free_cb);
+ WARN_ON(!dev->driver->load && dev->registered && !obj_free_cb && obj_type != DRM_MODE_OBJECT_PROPERTY);
mutex_lock(&dev->mode_config.idr_mutex);
ret = idr_alloc(&dev->mode_config.object_idr, register_obj ? obj : NULL,
--
2.43.0
Powered by blists - more mailing lists