linux-kernel - Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e92200e-d68c-4dc4-85c3-7192a23f8cbc@amd.com>
Date: Wed, 8 May 2024 15:07:16 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 fenghua.yu@...el.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, paulmck@...nel.org, rdunlap@...radead.org,
 tj@...nel.org, peterz@...radead.org, yanjiewtw@...il.com,
 kim.phillips@....com, lukas.bulwahn@...il.com, seanjc@...gle.com,
 jmattson@...gle.com, leitao@...ian.org, jpoimboe@...nel.org,
 rick.p.edgecombe@...el.com, kirill.shutemov@...ux.intel.com,
 jithu.joseph@...el.com, kai.huang@...el.com, kan.liang@...ux.intel.com,
 daniel.sneddon@...ux.intel.com, pbonzini@...hat.com, sandipan.das@....com,
 ilpo.jarvinen@...ux.intel.com, peternewman@...gle.com,
 maciej.wieczor-retman@...el.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, eranian@...gle.com, james.morse@....com
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)

Hi Reinette,

On 5/7/24 15:26, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/6/2024 10:18 AM, Moger, Babu wrote:
>> On 5/3/24 18:24, Reinette Chatre wrote:
>>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>>
>>>> a. Check if ABMC support is available
>>>> 	#mount -t resctrl resctrl /sys/fs/resctrl/
>>>>
>>>> 	#cat /sys/fs/resctrl/info/L3_MON/mbm_assign
>>>> 	[abmc] 
>>>> 	legacy_mbm
>>>>
>>>> 	Linux kernel detected ABMC feature and it is enabled.
>>>
>>> Please note that this adds the "abmc" feature to the resctrl
>>> *filesystem* that supports more architectures than just AMD. Calling the
>>> resctrl filesystem feature "abmc" means that (a) AMD needs to be ok with
>>> other architectures calling their features that are
>>> similar-but-maybe-not-identical-to-AMD-ABMC "abmc", or (b) this needs
>>> a new generic name.
>>
>> It should not a problem if other architecture calling abmc for similar
>> feature. But generic name is always better if there is a suggestion.
> 
> "should not a problem" does not instill confidence that AMD is
> actually ok with this.

The feature "ABMC" has been used in the public document already to refer
this feature.
https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24594.pdf

If there comes a conflict then we can change it to amd_abmc. Didn't see
any conflict at this pint.
-- 
Thanks
Babu Moger