linux-kernel - RE: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be00c7622f80474bbe4a9cffc16e3025@ti.com>
Date: Wed, 8 May 2024 20:32:20 +0000
From: "Saulnier, Nick" <nsaulnier@...com>
To: "Mendez, Judith" <jm@...com>, Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>
CC: "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rafael Beims
	<rafael.beims@...adex.com>,
        "Raghavendra, Vignesh" <vigneshr@...com>
Subject: RE: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to
 accommodate a safety margin

Tested on my side with the default 50% window across a range of periods. Works as expected. Details at 
https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1338070/am625-how-to-control-the-watchdog/5166032#5166032 

Regards,
Nick Saulnier

-----Original Message-----
From: Mendez, Judith 
Sent: Wednesday, May 08, 2024 1:50 PM
To: Wim Van Sebroeck <wim@...ux-watchdog.org>; Guenter Roeck <linux@...ck-us.net>
Cc: linux-watchdog@...r.kernel.org; linux-kernel@...r.kernel.org; Rafael Beims <rafael.beims@...adex.com>; Raghavendra, Vignesh <vigneshr@...com>; Saulnier, Nick <nsaulnier@...com>
Subject: Re: [PATCH v3] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin

Hi all,

On 4/17/24 3:57 PM, Judith Mendez wrote:
> On AM62x, the watchdog is pet before the valid window is open. Fix 
> min_hw_heartbeat and accommodate a 2% + static offset safety margin.
> The static offset accounts for max hardware error.
> 
> Remove the hack in the driver which shifts the open window boundary, 
> since it is no longer necessary due to the fix mentioned above.
> 

This patch has been sitting and there are no comments.
Please let me know if there is any issue with this patch, since I would like to get this fix merged (:

Thanks,
Judith