linux-kernel - Re: [PATCH 2/3] scripts/decode_stacktrace.sh: clarify command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n51sER+JsJed9406D8D74dh7dnYOykz9NVv1jHb8Pd--EQ@mail.gmail.com>
Date: Wed, 8 May 2024 17:37:53 -0400
From: Stephen Boyd <swboyd@...omium.org>
To: Alexis Lothoré <alexis.lothore@...tlin.com>, 
	Konstantin Khlebnikov <koct9i@...il.com>, Luca Ceresoli <luca.ceresoli@...tlin.com>, 
	Sasha Levin <sashal@...nel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] scripts/decode_stacktrace.sh: clarify command line

Quoting Luca Ceresoli (2024-03-11 08:24:55)
> The syntax as expressed by usage() is not entirely correct: "<modules
> path>" cannot be passed without "<base path>|auto". Additionally human
> reading of this syntax can be subject to misunderstanding due the mixture
> of '|' and '[]'.
>
> Improve readability in various ways:
>  * rewrite using two lines for the two allowed usages
>  * add square brackets around "<vmlinux>" as it is optional when using
>    debuginfod-find
>  * move "<modules path>" to inside the square brackets of the 2nd
>    positional parameter
>  * use underscores instead of spaces in <...> strings
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>