linux-kernel - Re: [PATCH v2 5/5] selftests: Drop duplicate -D_GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a28c1e66-db47-4ec6-8481-a114eaab78c5@nvidia.com>
Date: Wed, 8 May 2024 14:49:58 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Edward Liaw <edliaw@...gle.com>, <shuah@...nel.org>, Mark Brown
	<broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon
	<will@...nel.org>, Nhat Pham <nphamcs@...il.com>, Johannes Weiner
	<hannes@...xchg.org>, Christian Brauner <brauner@...nel.org>, Eric Biederman
	<ebiederm@...ssion.com>, Kees Cook <keescook@...omium.org>, OGAWA Hirofumi
	<hirofumi@...l.parknet.co.jp>, Thomas Gleixner <tglx@...utronix.de>, "Ingo
 Molnar" <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Darren
 Hart <dvhart@...radead.org>, Davidlohr Bueso <dave@...olabs.net>,
	André Almeida <andrealmeid@...lia.com>, Jiri Kosina
	<jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, Jason Gunthorpe
	<jgg@...pe.ca>, Kevin Tian <kevin.tian@...el.com>, Andy Lutomirski
	<luto@...capital.net>, Will Drewry <wad@...omium.org>, Marc Zyngier
	<maz@...nel.org>, Oliver Upton <oliver.upton@...ux.dev>, James Morse
	<james.morse@....com>, Suzuki K Poulose <suzuki.poulose@....com>, Zenghui Yu
	<yuzenghui@...wei.com>, Paolo Bonzini <pbonzini@...hat.com>, "Sean
 Christopherson" <seanjc@...gle.com>, Anup Patel <anup@...infault.org>, "Atish
 Patra" <atishp@...shpatra.org>, Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>, Janosch Frank
	<frankja@...ux.ibm.com>, Claudio Imbrenda <imbrenda@...ux.ibm.com>, "David
 Hildenbrand" <david@...hat.com>, Mickaël Salaün
	<mic@...ikod.net>, Paul Moore <paul@...l-moore.com>, James Morris
	<jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Andrew Morton
	<akpm@...ux-foundation.org>, Seth Forshee <sforshee@...nel.org>, Bongsu Jeon
	<bongsu.jeon@...sung.com>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Steffen Klassert <steffen.klassert@...unet.com>,
	"Herbert Xu" <herbert@...dor.apana.org.au>, Andreas Färber
	<afaerber@...e.de>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Matthieu Baerts <matttbe@...nel.org>, Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang@...nel.org>, Willem de Bruijn
	<willemdebruijn.kernel@...il.com>, Fenghua Yu <fenghua.yu@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>, Mathieu Desnoyers
	<mathieu.desnoyers@...icios.com>, "Paul E. McKenney" <paulmck@...nel.org>,
	Boqun Feng <boqun.feng@...il.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Jarkko Sakkinen <jarkko@...nel.org>, "Dave
 Hansen" <dave.hansen@...ux.intel.com>, Muhammad Usama Anjum
	<usama.anjum@...labora.com>
CC: <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<kernel-team@...roid.com>, <linux-sound@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mm@...ck.org>,
	<linux-input@...r.kernel.org>, <iommu@...ts.linux.dev>,
	<kvmarm@...ts.linux.dev>, <kvm@...r.kernel.org>,
	<kvm-riscv@...ts.infradead.org>, <linux-riscv@...ts.infradead.org>,
	<linux-security-module@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-actions@...ts.infradead.org>,
	<mptcp@...ts.linux.dev>, <linux-rtc@...r.kernel.org>,
	<linux-sgx@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] selftests: Drop duplicate -D_GNU_SOURCE

On 5/7/24 2:38 PM, Edward Liaw wrote:
> -D_GNU_SOURCE can be de-duplicated here, as it is added by
> KHDR_INCLUDES.
> 
> Signed-off-by: Edward Liaw <edliaw@...gle.com>
> ---

Most of the churn in these Makefiles can be avoided if it is possible to
take my recommendation on patch 3/5 [1].

However, as it is, it is correct, so if the above does not happen,
please feel free to add:

Reviewed-by: John Hubbard <jhubbard@...dia.com>


[1] https://lore.kernel.org/all/ec8ab737-a841-4cd5-8ec1-e0a777744262@nvidia.com/

thanks,
-- 
John Hubbard
NVIDIA

>   tools/testing/selftests/futex/functional/Makefile | 2 +-
>   tools/testing/selftests/iommu/Makefile            | 2 --
>   tools/testing/selftests/net/tcp_ao/Makefile       | 2 +-
>   tools/testing/selftests/resctrl/Makefile          | 2 +-
>   4 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
> index a392d0917b4e..f79f9bac7918 100644
> --- a/tools/testing/selftests/futex/functional/Makefile
> +++ b/tools/testing/selftests/futex/functional/Makefile
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)
> -CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE -pthread $(INCLUDES) $(KHDR_INCLUDES)
> +CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES)
>   LDLIBS := -lpthread -lrt
>   
>   LOCAL_HDRS := \
> diff --git a/tools/testing/selftests/iommu/Makefile b/tools/testing/selftests/iommu/Makefile
> index 32c5fdfd0eef..fd6477911f24 100644
> --- a/tools/testing/selftests/iommu/Makefile
> +++ b/tools/testing/selftests/iommu/Makefile
> @@ -2,8 +2,6 @@
>   CFLAGS += -Wall -O2 -Wno-unused-function
>   CFLAGS += $(KHDR_INCLUDES)
>   
> -CFLAGS += -D_GNU_SOURCE
> -
>   TEST_GEN_PROGS :=
>   TEST_GEN_PROGS += iommufd
>   TEST_GEN_PROGS += iommufd_fail_nth
> diff --git a/tools/testing/selftests/net/tcp_ao/Makefile b/tools/testing/selftests/net/tcp_ao/Makefile
> index 522d991e310e..c608b1ec02e6 100644
> --- a/tools/testing/selftests/net/tcp_ao/Makefile
> +++ b/tools/testing/selftests/net/tcp_ao/Makefile
> @@ -26,7 +26,7 @@ LIB	:= $(LIBDIR)/libaotst.a
>   LDLIBS	+= $(LIB) -pthread
>   LIBDEPS	:= lib/aolib.h Makefile
>   
> -CFLAGS	:= -Wall -O2 -g -D_GNU_SOURCE -fno-strict-aliasing
> +CFLAGS	:= -Wall -O2 -g -fno-strict-aliasing
>   CFLAGS	+= $(KHDR_INCLUDES)
>   CFLAGS	+= -iquote ./lib/ -I ../../../../include/
>   
> diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
> index 2deac2031de9..5073dbc96125 100644
> --- a/tools/testing/selftests/resctrl/Makefile
> +++ b/tools/testing/selftests/resctrl/Makefile
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   
> -CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE
> +CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2
>   CFLAGS += $(KHDR_INCLUDES)
>   
>   TEST_GEN_PROGS := resctrl_tests