linux-kernel - Re: [PATCH v2] net: usb: ax88179_178a: avoid writing the mac address before first reading

Open Source and information security mailing list archives

Message-ID: <CAMSo37UN11V8UeDM4cyD+iXyRR1Us53a00e34wTy+zP6vx935A@mail.gmail.com>
Date: Wed, 8 May 2024 13:42:36 +0800
From: Yongqin Liu <yongqin.liu@...aro.org>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com, 
	inventor500@...aldi.net, jarkko.palviainen@...il.com, 
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, 
	netdev@...r.kernel.org, pabeni@...hat.com, stable@...r.kernel.org, 
	vadim.fedorenko@...ux.dev, Sumit Semwal <sumit.semwal@...aro.org>, 
	John Stultz <jstultz@...gle.com>, Viktor Martensson <vmartensson@...gle.com>, 
	Amit Pundir <amit.pundir@...aro.org>
Subject: Re: [PATCH v2] net: usb: ax88179_178a: avoid writing the mac address
 before first reading

Hi, Jose

On Wed, 1 May 2024 at 00:01, Jose Ignacio Tornos Martinez
<jtornosm@...hat.com> wrote:
>
> > v6.8.8 has 56f78615b already. We need another patch, Jose?
>
> Hello Jakub,
>
> I will try to analyze it during the next week (I will be out until then).
>

Not sure if you have checked it already, this commit causes an issue for the
db845c + ACK android15-6.6[1] + AOSP main Android configuration, the
ethernet does not work,
there is no ip address assigned, like:
    db845c:/ # ifconfig eth0
    eth0      Link encap:Ethernet  HWaddr 02:00:89:7a:fb:61  Driver ax88179_178a
              UP BROADCAST MULTICAST  MTU:1500  Metric:1
              RX packets:0 errors:0 dropped:0 overruns:0 frame:0
              TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
              collisions:0 txqueuelen:1000
              RX bytes:0 TX bytes:0

    db845c:/ #
if I have this change reverted, then it will work again:
    db845c:/ # ifconfig eth0
    eth0      Link encap:Ethernet  HWaddr 02:00:89:7a:fb:61  Driver ax88179_178a
              inet addr:192.168.1.10  Bcast:192.168.1.255  Mask:255.255.255.0
              inet6 addr: 240e:305:2c88:4700:4b6d:926d:1592:fc5e/64
Scope: Global
              inet6 addr: 240e:305:2c88:4700:edc9:86ec:7c5e:b028/64
Scope: Global
              inet6 addr: fe80::32ce:8a2e:269d:e53f/64 Scope: Link
              UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
              RX packets:966 errors:0 dropped:33 overruns:0 frame:0
              TX packets:475 errors:0 dropped:0 overruns:0 carrier:0
              collisions:0 txqueuelen:1000
              RX bytes:51193 TX bytes:39472

    db845c:/ #

One thing to be noted here is that, during the boot, the MAC address
will be reassigned
to make sure each board has its own unique MAC address with the
following commands:
    /vendor/bin/ifconfig eth0 down
    /vendor/bin/ifconfig eth0 hw ether "${ETHADDR}"
    /vendor/bin/ifconfig eth0 up

Could you please help have a check and fix or give some suggestions on
this issue?

[1]: https://android.googlesource.com/kernel/common/+/refs/heads/android15-6.6
-- 
Best Regards,
Yongqin Liu
---------------------------------------------------------------
#mailing list
linaro-android@...ts.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-android

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives