linux-kernel - Re: [PATCH 2/3] MIPS: mobileye: Add EyeQ6H device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c4689c9-34a8-454a-a514-8ff0c77d74a8@kernel.org>
Date: Wed, 8 May 2024 09:28:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gregory CLEMENT <gregory.clement@...tlin.com>,
 Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
 Théo Lebrun <theo.lebrun@...tlin.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Tawfik Bayouk <tawfik.bayouk@...ileye.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH 2/3] MIPS: mobileye: Add EyeQ6H device tree

On 06/05/2024 18:16, Gregory CLEMENT wrote:
> EyeQ6H (or “High”) is an other SoC from Mobileye still based on the
> MIPS I6500 architecture as the EyeQ5. The 2 clusters of this SoC
> contains 4 cores which are capable of running 4 threads. Besides this,
> it features multiple controllers such as the classic UART, high speed
> I2C, SPI, as well as CAN-FD, PCIe Gen4, Octal/Quad SPI Flash
> interface, Gigabit Ethernet, MIPI CSI-2, MIPI DSI, and eMMC 5.1. It
> also includes a Hardware Security Module, Functional Safety Hardware,
> and video encoders and more.
> 
> This commit provides the initial device tree files with support for
> UART, GPIO and pinctrl, as well as fixed clocked.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
> ---
>  arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts        | 22 +++++
>  .../boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi     | 52 ++++++++++++
>  arch/mips/boot/dts/mobileye/eyeq6h-pins.dtsi       | 88 +++++++++++++++++++
>  arch/mips/boot/dts/mobileye/eyeq6h.dtsi            | 99 ++++++++++++++++++++++
>  4 files changed, 261 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts b/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
> new file mode 100644
> index 000000000000..ebc0d363fbf8
> --- /dev/null
> +++ b/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
> @@ -0,0 +1,22 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Copyright 2024 Mobileye Vision Technologies Ltd.
> + */
> +
> +/dts-v1/;
> +
> +#include "eyeq6h.dtsi"
> +
> +/ {
> +	compatible = "mobileye,eyeq6-epm6", "mobileye,eyeq6";
> +	model = "Mobile EyeQ6H MP6 Evaluation board";
> +
> +	chosen {
> +		stdout-path = "serial0:921600n8";
> +	};
> +
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x1 0x00000000 0x1 0x00000000>;
> +	};
> +};
> diff --git a/arch/mips/boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi b/arch/mips/boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi
> new file mode 100644
> index 000000000000..8bb806eb567e
> --- /dev/null
> +++ b/arch/mips/boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Copyright 2023 Mobileye Vision Technologies Ltd.
> + */
> +
> +#include <dt-bindings/clock/mobileye,eyeq5-clk.h>
> +
> +/ {
> +	xtal: xtal {

You should use common prefixes or even preferred clock node name.

https://lore.kernel.org/all/20240430180415.657067-1-robh@kernel.org/

..

> +
> +	soc: soc {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +		compatible = "simple-bus";

compatible is *always* the first property. This applies to all your
patches. See DTS coding style for the order.

Best regards,
Krzysztof