linux-kernel - Re: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 8 May 2024 10:55:07 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
cc: bhelgaas@...gle.com, dave.hansen@...ux.intel.com, x86@...nel.org, 
    linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'

On Wed, 8 May 2024, linux@...blig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> struct 'sim_reg_op' doesn't look like it was ever used.
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  arch/x86/pci/ce4100.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
>  	struct sim_reg sim_reg;
>  };
>  
> -struct sim_reg_op {
> -	void (*init)(struct sim_dev_reg *reg);
> -	void (*read)(struct sim_dev_reg *reg, u32 value);
> -	void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -

Thanks.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.