[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9530cd0a-a10d-49be-a415-e9d2351c0cbc@linaro.org>
Date: Wed, 8 May 2024 10:25:34 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: James Schulman <james.schulman@...rus.com>,
David Rhodes <david.rhodes@...rus.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>, Nuno Sá
<nuno.sa@...log.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Banajit Goswami <bgoswami@...cinc.com>
Cc: alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] ASoC: Constify channel mapping array arguments in
set_channel_map()
On 08/05/2024 10:16, Krzysztof Kozlowski wrote:
> There is no need for implementations of DAI set_channel_map() to modify
> contents of passed arrays with actual channel mapping. Additionally,
> the caller keeps full ownership of the array.
>
> Constify these pointer arguments so the code will be safer and easier to
> read (documenting the caller's ownership).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Oh, crap, I forgot Ack from Charles. I'll wait till tomorrow and send a
new version with the tag included (unless some review comes).
Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
Best regards,
Krzysztof
Powered by blists - more mailing lists