linux-kernel - Re: [PATCH net-next v17 02/13] rtase: Implement the .ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240508083643.GN15955@kernel.org>
Date: Wed, 8 May 2024 09:36:43 +0100
From: Simon Horman <horms@...nel.org>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: "kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"jiri@...nulli.us" <jiri@...nulli.us>,
	Ping-Ke Shih <pkshih@...ltek.com>,
	Larry Chiu <larry.chiu@...ltek.com>
Subject: Re: [PATCH net-next v17 02/13] rtase: Implement the .ndo_open
 function

On Mon, May 06, 2024 at 02:45:11AM +0000, Justin Lai wrote:

..

> > > +
> > > +             /* request other interrupts to handle multiqueue */
> > > +             for (i = 1; i < tp->int_nums; i++) {
> > > +                     ivec = &tp->int_vector[i];
> > > +                     snprintf(ivec->name, sizeof(ivec->name),
> > > + "%s_int%i", tp->dev->name, i);
> > 
> > nit: This line could trivially be split into two lines,
> >      each less than 80 columns wide.
> > 
> I will check if there are other similar issues and make corrections.

Thanks.

FWIIW, checkpatch.pl --max-line-length=80 can be helpful here.