[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87a5l0lmlv.fsf@intel.com>
Date: Wed, 08 May 2024 11:43:56 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Abhinav Kumar <quic_abhinavk@...cinc.com>,
freedreno@...ts.freedesktop.org, Rob Clark <robdclark@...il.com>, Abhinav
Kumar <quic_abhinavk@...cinc.com>, Dmitry Baryshkov
<dmitry.baryshkov@...aro.org>, Sean Paul <sean@...rly.run>, Marijn Suijten
<marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, Daniel
Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, seanpaul@...omium.org,
swboyd@...omium.org, quic_jesszhan@...cinc.com,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, Masahiro
Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm
On Tue, 07 May 2024, Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
> Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"),
> compilation is broken on machines having python versions older than 3.9
> due to dependency on argparse.BooleanOptionalAction.
Is it now okay to require Python for the build? Not listed in
Documentation/process/changes.rst.
BR,
Jani.
>
> Switch to use simple bool for the validate flag to remove the dependency.
>
> Fixes: 5acf49119630 ("drm/msm: import gen_header.py script from Mesa")
> Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> ---
> drivers/gpu/drm/msm/registers/gen_header.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/registers/gen_header.py b/drivers/gpu/drm/msm/registers/gen_header.py
> index fc3bfdc991d2..3926485bb197 100644
> --- a/drivers/gpu/drm/msm/registers/gen_header.py
> +++ b/drivers/gpu/drm/msm/registers/gen_header.py
> @@ -538,7 +538,7 @@ class Parser(object):
> self.variants.add(reg.domain)
>
> def do_validate(self, schemafile):
> - if self.validate == False:
> + if not self.validate:
> return
>
> try:
> @@ -948,7 +948,8 @@ def main():
> parser = argparse.ArgumentParser()
> parser.add_argument('--rnn', type=str, required=True)
> parser.add_argument('--xml', type=str, required=True)
> - parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> + parser.add_argument('--validate', default=False, action='store_true')
> + parser.add_argument('--no-validate', dest='validate', action='store_false')
>
> subparsers = parser.add_subparsers()
> subparsers.required = True
--
Jani Nikula, Intel
Powered by blists - more mailing lists