linux-kernel - Re: [tip: timers/urgent] timers/migration: Prevent out of bounds access on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 8 May 2024 12:57:11 +0300
From: Andy Shevchenko <andy@...ck.fi.intel.com>
To: linux-kernel@...r.kernel.org
Cc: linux-tip-commits@...r.kernel.org, Levi Yun <ppbuk5246@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Anna-Maria Behnsen <anna-maria@...utronix.de>, x86@...nel.org
Subject: Re: [tip: timers/urgent] timers/migration: Prevent out of bounds
 access on failure

On Wed, May 08, 2024 at 09:45:41AM -0000, tip-bot2 for Levi Yun wrote:
> The following commit has been merged into the timers/urgent branch of tip:

(Yes, I noted above)

..

> -	do {
> +	while (i > 0) {
>  		group = stack[--i];

Looking at this and most used patterns for cleanup loops, I would amend
this to

	while (i--) {
		group = stack[i];

which seems to me an equivalent.

>  		if (err < 0) {
> @@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
>  				tmigr_connect_child_parent(child, group);
>  			}
>  		}
> -	} while (i > 0);
> +	}

-- 
With Best Regards,
Andy Shevchenko