linux-kernel - Re: [PATCH v2] net/sched: adjust device watchdog timer to detect stopped queue at right time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 7 May 2024 17:30:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Praveen Kumar Kannoju <praveen.kannoju@...cle.com>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 rajesh.sivaramasubramaniom@...cle.com, rama.nichanamatlu@...cle.com,
 manjunath.b.patil@...cle.com
Subject: Re: [PATCH v2] net/sched: adjust device watchdog timer to detect
 stopped queue at right time

LGTM! 

One nit..

On Mon,  6 May 2024 19:29:44 +0530 Praveen Kumar Kannoju wrote:
> +				if (time_after(jiffies, (trans_start + dev->watchdog_timeo))) {
                                                        ^                                 ^

Would you mind dropping these brackets while you're touching this line?
They are unnecessary.