lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 7 May 2024 21:42:06 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf dwarf-aux: Print array type name with "[]"

On Wed, May 08, 2024 at 08:57:51AM +0900, Masami Hiramatsu wrote:
> On Mon,  6 May 2024 21:13:38 -0700
> Namhyung Kim <namhyung@...nel.org> wrote:
> 
> > It's confusing both pointers and arrays are printed as *.  Let's print
> > array types with [] so that we can identify them easily.  Although it's
> > interchangable, sometimes it can cause confusion with size like in the
> > below example.
> > 
> > Note that it is not the same with C syntax where it goes to the variable
> > names, but we want to have it in the type names (like in Go language).
> > 
> > Before:
> >   mov [20] 0x68(reg5) -> reg0 type='struct page**' size=0x80 (die:0x4e61d32)
> > 
> > After:
> >   mov [20] 0x68(reg5) -> reg0 type='struct page*[]' size=0x80 (die:0x4e61d32)
> > 
> 
> Good improvement!
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Indeed,

Thanks, applied to perf-tools-next,

- Arnaldo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ