linux-kernel - Re: [PATCH RFC v6 09/10] iio: adc: ad7380: add support for rolling average oversampling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240508122556.00005f71@Huawei.com>
Date: Wed, 8 May 2024 12:25:56 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: David Lechner <dlechner@...libre.com>
CC: Jonathan Cameron <jic23@...nel.org>, Julien Stephan
	<jstephan@...libre.com>, Lars-Peter Clausen <lars@...afoo.de>, "Michael
 Hennerich" <Michael.Hennerich@...log.com>, Nuno Sá
	<nuno.sa@...log.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Liam
 Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, kernel test
 robot <lkp@...el.com>, <linux-iio@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC v6 09/10] iio: adc: ad7380: add support for rolling
 average oversampling mode

On Mon, 6 May 2024 10:04:10 -0500
David Lechner <dlechner@...libre.com> wrote:

> On Mon, May 6, 2024 at 9:17 AM Jonathan Cameron <jic23@...nel.org> wrote:
> >
> > On Wed, 01 May 2024 16:55:42 +0200
> > Julien Stephan <jstephan@...libre.com> wrote:
> >  
> > > Adds support for rolling average oversampling mode.
> > >
> > > Rolling oversampling mode uses a first in, first out (FIFO) buffer of
> > > the most recent samples in the averaging calculation, allowing the ADC
> > > throughput rate and output data rate to stay the same, since we only need
> > > to take only one sample for each new conversion.
> > >
> > > The FIFO length is 8, thus the available oversampling ratios are 1, 2, 4, 8
> > > in this mode (vs 1,  2, 4, 8, 16, 32 for the normal average)  
> >
> > Ah. I should have read on!
> >  
> > >
> > > In order to be able to change the averaging mode, this commit also adds
> > > the new "oversampling_mode" and "oversampling_mode_available" custom
> > > attributes along with the according documentation file in
> > > Documentation/ABI/testing/sysfs-bus-iio-adc-ad7380 since no standard
> > > attributes correspond to this use case.  
> >
> > This comes to the comment I stuck in the previous patch.
> >
> > To most people this is not a form of oversampling because the data rate
> > remains unchanged. It's a cheap low pass filter (boxcar) Google pointed me at:
> > https://dsp.stackexchange.com/questions/9966/what-is-the-cut-off-frequency-of-a-moving-average-filter
> >
> > in_voltage_low_pass_3db_frequency would be the most appropriate standard
> > ABI for this if we do treat it as a low pass filter control.
> >
> > I'm not necessarily saying we don't want new ABI for this, but I would
> > like to consider the pros and cons of just using the 3db frequency.
> >
> > So would that work for this part or am I missing something?
> >  
> 
> I like the idea. But from the link, it looks like the 3dB frequency
> depends on the sampling frequency which is unknown (e.g. could come
> from hrtimer trigger).
> 
> Would it be reasonable to calculate the 3db frequency at the max
> sample rate that the chip allows and just use those numbers?
> 
Ah. So looking at datasheet the normal average oversampling is
self clocked, but this version is not.

So, I'll ask the dumb question.  What is this feature for?
We have to pump the SPI bus anyway why not just do the maths in
userspace?  Oversampling is normally about data rate reduction
with a bonus in precision obtained.

Jonathan