linux-kernel - Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjtnvjlJpfNn7qVT@finisterre.sirena.org.uk>
Date: Wed, 8 May 2024 20:53:34 +0900
From: Mark Brown <broonie@...nel.org>
To: Alina Yu <alina_yu@...htek.com>
Cc: lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	johnny_lai@...htek.com, cy_huang@...htek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout

On Wed, May 08, 2024 at 02:54:02PM +0800, Alina Yu wrote:

> May I modify the code into this ?
> I'll add 'richtek,fixed-microvolt' property in dtsi; remove 'regulator-min-microvolt' and 'regulator-max-microvolt'
> to prevent fail caused by constraints->apply_uV.

Adding the new property seems fine.  You still need to permit the
min/max microvolt properties for the case where the regulator is in
normal mode and can vary, you could write rules that ensure that the
constraints line up in the case where a fixed voltage is specified but
I'm not sure it's worth the effort.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)