linux-kernel - Re: [PATCH 1/4] mm/ksm: fix ksm_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 8 May 2024 14:32:51 +0200
From: David Hildenbrand <david@...hat.com>
To: Chengming Zhou <chengming.zhou@...ux.dev>,
 Andrew Morton <akpm@...ux-foundation.org>, Stefan Roesch <shr@...kernel.io>,
 xu xin <xu.xin16@....com.cn>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 zhouchengming@...edance.com
Subject: Re: [PATCH 1/4] mm/ksm: fix ksm_pages_scanned accounting

On 08.05.24 12:35, Chengming Zhou wrote:
> On 2024/5/8 17:55, Chengming Zhou wrote:
>> During testing, I found ksm_pages_scanned is unchanged although the
>> scan_get_next_rmap_item() did return valid rmap_item that is not NULL.
>>
>> The reason is the scan_get_next_rmap_item() will return NULL after
>> a full scan, so ksm_do_scan() just return without accounting of the
>> ksm_pages_scanned.
>>
>> Fix it by just putting ksm_pages_scanned accounting in that loop,
>> and it will be accounted more timely if that loop would last for
>> a long time.
>>
> 
> Fixes: b348b5fe2b5f ("mm/ksm: add pages scanned metric")

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb