linux-kernel - Re: [PATCH v3 4/4] selftests/mm: Add new testcases for pkeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871q6cpinn.ffs@tglx>
Date: Wed, 08 May 2024 14:55:40 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>, "dave.hansen@...ux.intel.com"
 <dave.hansen@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>, Keith Lucas
 <keith.lucas@...cle.com>
Subject: Re: [PATCH v3 4/4] selftests/mm: Add new testcases for pkeys

On Tue, May 07 2024 at 18:04, Aruna Ramakrishna wrote:
>> On May 7, 2024, at 9:56 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
>> 
>> On Tue, May 07 2024 at 14:05, Thomas Gleixner wrote:
>>> On Thu, Apr 25 2024 at 18:05, Aruna Ramakrishna wrote:
>>>> especially with pkey 0 disabled.
>>>> 
>>>> Signed-off-by: Keith Lucas <keith.lucas@...cle.com>
>>>> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
>> 
>> Forgot to mention that this Signed-off-by chain is invalid.
>
> Apologies for what is probably an obvious question.
>
> Keith Lucas developed the testcases in the new file pkey_sighandler_testsc.
>
> I added them to tools/testing/selftests/mm (i.e. just the changes
> to Makefile, protection_keys.c and some comments etc.).
>
> So should I change this to:
>
> Co-developed-by: Keith Lucas <keith.lucas@...cle.com>
> Signed-off-by: Keith Lucas <keith.lucas@...cle.com>
> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>

If Keith developed them, then you probably want to credit him as author.

[ aruna: Adopted to upstream ]

Signed-off-by: Keith Lucas <keith.lucas@...cle.com>
Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>

Or split out the pkey helper changes into a separate patch which is
authored by you.

Either way works just fine.

Thanks,

        tglx