[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <875b643f-af2c-4a1b-87e8-80cd6f236dea@linux.intel.com>
Date: Tue, 7 May 2024 16:23:51 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Wesley Cheng <quic_wcheng@...cinc.com>, srinivas.kandagatla@...aro.org,
mathias.nyman@...el.com, perex@...ex.cz, conor+dt@...nel.org,
corbet@....net, lgirdwood@...il.com, andersson@...nel.org,
krzk+dt@...nel.org, gregkh@...uxfoundation.org, Thinh.Nguyen@...opsys.com,
broonie@...nel.org, bgoswami@...cinc.com, tiwai@...e.com,
bagasdotme@...il.com, robh@...nel.org, konrad.dybcio@...aro.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-sound@...r.kernel.org, linux-usb@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-doc@...r.kernel.org,
alsa-devel@...a-project.org
Subject: Re: [PATCH v21 26/39] ASoC: qcom: qdsp6: Add support to track
available USB PCM devices
> @@ -113,6 +120,12 @@ static int q6usb_alsa_connection_cb(struct snd_soc_usb *usb,
> if (connected) {
> /* We only track the latest USB headset plugged in */
> data->active_usb_chip_idx = sdev->card_idx;
> +
> + set_bit(sdev->card_idx, &data->available_card_slot);
> + data->status[sdev->card_idx].sdev = sdev;
Not following the 'only track the latest USB headset plugged in', I
don't see anything that discard the previously latest headset...
If you plug headset1, then headset2, how is headset1 marked as not
available for USB offload?
> + } else {
> + clear_bit(sdev->card_idx, &data->available_card_slot);
> + data->status[sdev->card_idx].sdev = NULL;
> }
>
> return 0;
Powered by blists - more mailing lists