linux-kernel - Re: linux-next: build failure after merge of the bitmap tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zjt9GRTRgjfgtOwd@visitorckw-System-Product-Name>
Date: Wed, 8 May 2024 21:24:41 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: Yury Norov <yury.norov@...il.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the bitmap tree

On Wed, May 08, 2024 at 04:27:55PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bitmap tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> lib/test_bitops.c: In function 'test_fns':
> lib/test_bitops.c:56:9: error: cleanup argument not a function
>    56 |         unsigned long *buf __free(kfree) = NULL;
>       |         ^~~~~~~~
> lib/test_bitops.c:60:15: error: implicit declaration of function 'kmalloc_array' [-Werror=implicit-function-declaration]
>    60 |         buf = kmalloc_array(10000, sizeof(unsigned long), GFP_KERNEL);
>       |               ^~~~~~~~~~~~~
> lib/test_bitops.c:60:13: error: assignment to 'long unsigned int *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>    60 |         buf = kmalloc_array(10000, sizeof(unsigned long), GFP_KERNEL);
>       |             ^
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   777c893e12fa ("lib/test_bitops: Add benchmark test for fns()")
>
> I have used the bitmap tree from next-20240507 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell

Hi Yury,

I believe the following patch can resolve this issue. If you agree that
this patch is correct, could you help me fold it into the commit that
caused the error mentioned above?

Regards,
Kuan-Wei

>From e028ad2415fc1b9cf7f59faa298ac7d6c2723b4a Mon Sep 17 00:00:00 2001
From: Kuan-Wei Chiu <visitorckw@...il.com>
Date: Wed, 8 May 2024 21:16:50 +0800
Subject: [PATCH] lib/test_bitops: Fix compilation error on ppc64_defconfig

Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
---
 lib/test_bitops.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/test_bitops.c b/lib/test_bitops.c
index ee4759ced0f6..564bc486b599 100644
--- a/lib/test_bitops.c
+++ b/lib/test_bitops.c
@@ -8,6 +8,7 @@
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/printk.h>
+#include <linux/slab.h>
 
 /* a tiny module only meant to test
  *
-- 
2.34.1