linux-kernel - Re: [PATCH v5 2/3] x86/bugs: Remove duplicate Spectre cmdline option descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c88c185-cf9f-470c-8d7c-2b933d9419bc@linux.intel.com>
Date: Wed, 8 May 2024 07:28:35 -0700
From: Daniel Sneddon <daniel.sneddon@...ux.intel.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>,
 Alexandre Chartre <alexandre.chartre@...cle.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
 Peter Zijlstra <peterz@...radead.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Sean Christopherson <seanjc@...gle.com>,
 Andrew Cooper <andrew.cooper3@...rix.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Nikolay Borisov <nik.borisov@...e.com>, KP Singh <kpsingh@...nel.org>,
 Waiman Long <longman@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v5 2/3] x86/bugs: Remove duplicate Spectre cmdline option
 descriptions

On 5/7/24 22:55, Josh Poimboeuf wrote:
> On Tue, May 07, 2024 at 08:04:37AM -0700, Daniel Sneddon wrote:
>> I love the idea here, but
>>
>>>  	nospectre_v2
>>> +	spectre_v2={option}
>>> +	spectre_v2_user={option}
>>> +	spectre_bhi={option}
>>>  
>>
>> this comes out as just a single line when I run make htmldocs.
> 
> Thanks, the below turns it into a bulleted list:
> 
> diff --git a/Documentation/admin-guide/hw-vuln/spectre.rst b/Documentation/admin-guide/hw-vuln/spectre.rst
> index f9797ab6b38f..132e0bc6007e 100644
> --- a/Documentation/admin-guide/hw-vuln/spectre.rst
> +++ b/Documentation/admin-guide/hw-vuln/spectre.rst
> @@ -598,11 +598,11 @@ current CPU.
>  Spectre default mitigations can be disabled or changed at the kernel
>  command line with the following options:
>  
> -	nospectre_v1
> -	nospectre_v2
> -	spectre_v2={option}
> -	spectre_v2_user={option}
> -	spectre_bhi={option}
> +	- nospectre_v1
> +	- nospectre_v2
> +	- spectre_v2={option}
> +	- spectre_v2_user={option}
> +	- spectre_bhi={option}
>  
>  For more details on the available options, refer to Documentation/admin-guide/kernel-parameters.txt
>  

Looks good.

Reviewed-by: Daniel Sneddon <daniel.sneddon@...ux.intel.com>