linux-kernel - RE: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5866F14FA9B7D02BC97942F5E5E52@SJ0PR11MB5866.namprd11.prod.outlook.com>
Date: Wed, 8 May 2024 14:42:23 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Lobakin, Aleksander" <aleksander.lobakin@...el.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>
CC: Alexei Starovoitov <ast@...nel.org>, Jesper Dangaard Brouer
	<hawk@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Richard Cochran
	<richardcochran@...il.com>, John Fastabend <john.fastabend@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Eric Dumazet
	<edumazet@...gle.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, Jakub Kicinski <kuba@...nel.org>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y
 instead of *-objs in Makefile



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On
> Behalf Of Alexander Lobakin
> Sent: Wednesday, May 8, 2024 4:40 PM
> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Alexei Starovoitov <ast@...nel.org>; Jesper Dangaard Brouer
> <hawk@...nel.org>; Daniel Borkmann <daniel@...earbox.net>;
> netdev@...r.kernel.org; Richard Cochran <richardcochran@...il.com>;
> John Fastabend <john.fastabend@...il.com>; linux-
> kernel@...r.kernel.org; Eric Dumazet <edumazet@...gle.com>; intel-
> wired-lan@...ts.osuosl.org; Jakub Kicinski <kuba@...nel.org>;
> Keller, Jacob E <jacob.e.keller@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; bpf@...r.kernel.org; Paolo Abeni
> <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel:
> Use *-y instead of *-objs in Makefile
> 
> From: Alexander Lobakin <aleksander.lobakin@...el.com>
> Date: Wed, 8 May 2024 16:39:21 +0200
> 
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Date: Wed, 8 May 2024 17:25:31 +0300
> >
> >> On Wed, May 08, 2024 at 03:35:26PM +0200, Alexander Lobakin
> wrote:
> >>>> *-objs suffix is reserved rather for (user-space) host
> programs
> >>>> while usually *-y suffix is used for kernel drivers (although
> >>>> *-objs works for that purpose for now).
> >>>>
> >>>> Let's correct the old usages of *-objs in Makefiles.
> >>>
> >>> Wait, I was sure I've seen somewhere that -objs is more new and
> >>> preferred over -y.
> >>
> >> Then you are mistaken.
> >>
> >>> See recent dimlib comment where Florian changed -y to -objs for
> >>> example.
> >>
> >> So does he :-)
> >>
> >>> Any documentation reference that -objs is for userspace and we
> >>> should clearly use -y?
> >>
> >> Sure. Luckily it's documented in
> Documentation/kbuild/makefiles.rst
> >> "Composite Host Programs" (mind the meaning of the word
> "host"!).
> >
> > Oh okay, I see. `-objs` is indeed only mentioned in the host
> chapter.
> 
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> Thanks,
> Olek

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>