[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240508144259.191843-1-jan.dakinevich@salutedevices.com>
Date: Wed, 8 May 2024 17:42:56 +0300
From: Jan Dakinevich <jan.dakinevich@...utedevices.com>
To: Jan Dakinevich <jan.dakinevich@...utedevices.com>, Conor Dooley
<conor+dt@...nel.org>, <devicetree@...r.kernel.org>, Jerome Brunet
<jbrunet@...libre.com>, Kevin Hilman <khilman@...libre.com>, Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
<linux-amlogic@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Martin
Blumenstingl <martin.blumenstingl@...glemail.com>, Michael Turquette
<mturquette@...libre.com>, Neil Armstrong <neil.armstrong@...aro.org>, Rob
Herring <robh+dt@...nel.org>, Stephen Boyd <sboyd@...nel.org>
Subject: [QUESTION] Convert axg-audio-clkc to YAML format
Previously we discussed how to implement dt-schema for audio clock controller in
Amlogic SoC [1]. Also, there was an earlier attempt to convert to yaml [2].
Let me remind you that the problem is that only "pclk" clock of this controller.
Other clocks are optional and they are allowed to be not routed.
I can suggest two approaches how to deal with this. Could you please tell me
which of them is more correct?
Approach 1: use 'additionalItems' to declare optional clocks.
Pros:
- it is short and simple;
- no need to modify existing DTSIs.
Cons:
- checking works but 'additionalItems' doesn't expect no-boolean value [3]
- there is reasoning that all clocks should be specified ragardless if they are
used or not [3][4].
Approach 2: assume that all clocks are mandatory and declare all of them.
Pros:
- it is more common and compatible with existing meta-schemas;
- may be architecturally it is more correct.
Cons:
- boilerplate in schema and in DTSIs;
- requires modification of existing DTSIs.
Links:
[1] https://lore.kernel.org/lkml/20240419125812.983409-5-jan.dakinevich@salutedevices.com/
[2] https://lore.kernel.org/linux-devicetree/20230808194811.113087-1-alexander.stein@mailbox.org/
[3] https://lore.kernel.org/lkml/20240419210949.GA3979121-robh@kernel.org/
[4] https://lore.kernel.org/lkml/07b1ca57-49a0-4151-99bf-caac053eaa01@kernel.org/
--
2.34.1
Powered by blists - more mailing lists