linux-kernel - Re: [External] Re: [PATCH v4 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 08 May 2024 07:53:44 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: cuiyunhui@...edance.com, Sunil V L <sunilvl@...tanamicro.com>
CC: Conor Dooley <conor@...nel.org>, rafael@...nel.org, lenb@...nel.org,
  linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, Paul Walmsley <paul.walmsley@...ive.com>,
  aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org, bhelgaas@...gle.com, james.morse@....com,
  jhugo@...eaurora.org, jeremy.linton@....com, john.garry@...wei.com, Jonathan.Cameron@...wei.com,
  pierre.gondois@....com, sudeep.holla@....com, tiantao6@...wei.com
Subject:     Re: [External] Re: [PATCH v4 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT

On Wed, 08 May 2024 04:19:01 PDT (-0700), cuiyunhui@...edance.com wrote:
> Hi Palmer,
>
> Gentle ping...

+Sunil, as he's the ACPI/RISC-V maintainer and I generally wait for his 
review on this stuff.

>
> On Fri, May 3, 2024 at 12:37 AM Conor Dooley <conor@...nel.org> wrote:
>>
>> On Thu, Apr 18, 2024 at 11:43:29AM +0800, Yunhui Cui wrote:
>> > Before cacheinfo can be built correctly, we need to initialize level
>> > and type. Since RSIC-V currently does not have a register group that
>> > describes cache-related attributes like ARM64, we cannot obtain them
>> > directly, so now we obtain cache leaves from the ACPI PPTT table
>> > (acpi_get_cache_info()) and set the cache type through split_levels.
>> >
>> > Suggested-by: Jeremy Linton <jeremy.linton@....com>
>> > Suggested-by: Sudeep Holla <sudeep.holla@....com>
>> : Signed-off-by: Yunhui Cui <cuiyunhui@...edance.com>
>>
>> I'm not an ACPI head, so whether or not the table is valid on RISC-V or
>> w/e I do not know, but the code here looks sane to me, so
>
>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
>>
>> Cheers,
>> Conor.
>
> Thanks,
> Yunhui