linux-kernel - Re: [PATCH net-next v3] selftest: epoll_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240508082533.37a49678@kernel.org>
Date: Wed, 8 May 2024 08:25:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, nalramli@...tly.com, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net-next v3] selftest: epoll_busy_poll: epoll busy poll
 tests

On Tue, 7 May 2024 19:21:50 -0700 Joe Damato wrote:
> On Wed, May 08, 2024 at 12:43:26AM +0000, Joe Damato wrote:
> > Add a simple test for the epoll busy poll ioctls, using the kernel
> > selftest harness.
> > 
> > This test ensures that the ioctls have the expected return codes and
> > that the kernel properly gets and sets epoll busy poll parameters.
> > 
> > The test can be expanded in the future to do real busy polling (provided
> > another machine to act as the client is available).  
> 
> Ah, built and worked for me, but of course fails remotely:
> 
> epoll_busy_poll.c:20:10: fatal error: sys/capability.h: No such file or directory
>    20 | #include <sys/capability.h>
>       |          ^~~~~~~~~~~~~~~~~~
> 
> Looks like selftests/bpf/cap_helpers.c avoids a similar-ish issue? Not sure if
> there's a better way or if I should do something like that?
> 
> I assume it is not possible to add deps like libcap-dev to the test harness somehow?

Ah sorry, CI builder was missing the libcap-devel package.
I can't retrigger the CI easily, unfortunately, could you repost?
(without the 24h wait)