linux-kernel - Re: [PATCH] btrfs: scrub: fix a compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240508153735.GB372255@zen.localdomain>
Date: Wed, 8 May 2024 08:37:35 -0700
From: Boris Burkov <boris@....io>
To: Lu Yao <yaolu@...inos.cn>
Cc: clm@...com, josef@...icpanda.com, dsterba@...e.com,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: scrub: fix a compilation warning

On Tue, May 07, 2024 at 10:34:17AM +0800, Lu Yao wrote:
> The following error message is displayed:
>   ../fs/btrfs/scrub.c:2152:9: error: ‘ret’ may be used uninitialized
>   in this function [-Werror=maybe-uninitialized]"
> 
> Signed-off-by: Lu Yao <yaolu@...inos.cn>
Reviewed-by: Boris Burkov <boris@....io>
> ---
> gcc version: (Debian 10.2.1-6) 10.2.1 20210110
> ---
>  fs/btrfs/scrub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
> index 4b22cfe9a98c..afd6932f5e89 100644
> --- a/fs/btrfs/scrub.c
> +++ b/fs/btrfs/scrub.c
> @@ -2100,7 +2100,7 @@ static int scrub_simple_mirror(struct scrub_ctx *sctx,
>  	struct btrfs_fs_info *fs_info = sctx->fs_info;
>  	const u64 logical_end = logical_start + logical_length;
>  	u64 cur_logical = logical_start;
> -	int ret;
> +	int ret = 0;
>  
>  	/* The range must be inside the bg */
>  	ASSERT(logical_start >= bg->start && logical_end <= bg->start + bg->length);
> -- 
> 2.25.1
>