linux-kernel - Re: [PATCH 2/3] f2fs: fix to add missing iput() in gc_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32e097e6-67f1-4f06-bad0-0c7b3afb46f0@kernel.org>
Date: Thu, 9 May 2024 10:49:16 +0800
From: Chao Yu <chao@...nel.org>
To: Jaegeuk Kim <jaegeuk@...nel.org>
Cc: linux-f2fs-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] f2fs: fix to add missing iput() in gc_data_segment()

On 2024/5/9 8:46, Jaegeuk Kim wrote:
> On 05/06, Chao Yu wrote:
>> During gc_data_segment(), if inode state is abnormal, it missed to call
>> iput(), fix it.
>>
>> Fixes: 132e3209789c ("f2fs: remove false alarm on iget failure during GC")
>> Fixes: 9056d6489f5a ("f2fs: fix to do sanity check on inode type during garbage collection")
>> Signed-off-by: Chao Yu <chao@...nel.org>
>> ---
>>   fs/f2fs/gc.c | 9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>> index 8852814dab7f..e86c7f01539a 100644
>> --- a/fs/f2fs/gc.c
>> +++ b/fs/f2fs/gc.c
>> @@ -1554,10 +1554,15 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
>>   			int err;
>>   
>>   			inode = f2fs_iget(sb, dni.ino);
>> -			if (IS_ERR(inode) || is_bad_inode(inode) ||
>> -					special_file(inode->i_mode))
>> +			if (IS_ERR(inode))
>>   				continue;
>>   
>> +			if (is_bad_inode(inode) ||
>> +					special_file(inode->i_mode)) {
>> +				iput(inode);
> 
> iget_failed() called iput()?

It looks the bad inode was referenced in this context, it needs to be iput()ed
here.

The bad inode was made in other thread, please check description in commit
b73e52824c89 ("f2fs: reposition unlock_new_inode to prevent accessing invalid
inode").

Thanks,

> 
> 
>> +				continue;
>> +			}
>> +
>>   			err = f2fs_gc_pinned_control(inode, gc_type, segno);
>>   			if (err == -EAGAIN) {
>>   				iput(inode);
>> -- 
>> 2.40.1