linux-kernel - Re: [PATCH RESEND v5 2/2] regulator: sun20i: Add Allwinner D1 LDOs driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjxWKOoLMNQAmhla@finisterre.sirena.org.uk>
Date: Thu, 9 May 2024 06:50:48 +0200
From: Mark Brown <broonie@...nel.org>
To: Chen-Yu Tsai <wens@...nel.org>
Cc: Samuel Holland <samuel@...lland.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
	Andre Przywara <andre.przywara@....com>,
	Chen-Yu Tsai <wens@...e.org>
Subject: Re: [PATCH RESEND v5 2/2] regulator: sun20i: Add Allwinner D1 LDOs
 driver

On Tue, May 07, 2024 at 12:13:43PM +0800, Chen-Yu Tsai wrote:
> From: Samuel Holland <samuel@...lland.org>
> 
> D1 contains two pairs of LDOs, "analog" LDOs and "system" LDOs. They are
> similar and can share a driver, but only the system LDOs have a DT
> binding defined so far.

This doesn't build on at least multi_v5_defconfig, multi_v7_defconfig
and arm64 defconfig:

/build/stage/linux/drivers/regulator/sun20i-regulator.c: In function ‘sun20i_reg
ulator_probe’:
/build/stage/linux/drivers/regulator/sun20i-regulator.c:111:16: error: implicit 
declaration of function ‘of_device_get_match_data’ [-Werror=implicit-function-de
claration]
  111 |         data = of_device_get_match_data(dev);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/regulator/sun20i-regulator.c:111:14: warning: assignm
ent to ‘const struct sun20i_regulator_data *’ from ‘int’ makes pointer from inte
ger without a cast [-Wint-conversion]
  111 |         data = of_device_get_match_data(dev);
      |              ^
/build/stage/linux/drivers/regulator/sun20i-regulator.c: At top level:
/build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: error: array typ
e has incomplete element type ‘struct of_device_id’
  136 | static const struct of_device_id sun20i_regulator_of_match[] = {
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: warning: ‘sun20i
_regulator_of_match’ defined but not used [-Wunused-variable]

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)