linux-kernel - Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjxWkleEdk5iUxI8@infradead.org>
Date: Wed, 8 May 2024 21:52:34 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Barry Song <21cnbao@...il.com>
Cc: hailong.liu@...o.com, akpm@...ux-foundation.org, urezki@...il.com,
	hch@...radead.org, lstoakes@...il.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, xiang@...nel.org, chao@...nel.org,
	Oven <liyangouwen1@...o.com>
Subject: Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if
 called with __GFP_NOFAIL

On Thu, May 09, 2024 at 02:20:03PM +1200, Barry Song wrote:
> reverting the fix intended to address the OOM-killer issue in commit
> dd544141b9eb.
> Should we indeed permit the NOFAIL flag for large kvmalloc allocations?

What is large?  When you don't allow actually use cases people will
just reimplement it poorly.  E.g. we'd probably have to add back the
XFS kmem_ wrappers.