linux-kernel - Re: [RFC 0/4] perf sched: Introduce schedstat tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91a904c3-fe6c-2e0f-0af9-6c687ce45c4e@amd.com>
Date: Thu, 9 May 2024 10:39:11 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: Ian Rogers <irogers@...gle.com>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
 namhyung@...nel.org, swapnil.sapkal@....com, mark.rutland@....com,
 alexander.shishkin@...ux.intel.com, jolsa@...nel.org, rostedt@...dmis.org,
 vincent.guittot@...aro.org, bristot@...hat.com, adrian.hunter@...el.com,
 james.clark@....com, kan.liang@...ux.intel.com, gautham.shenoy@....com,
 kprateek.nayak@....com, juri.lelli@...hat.com, yangjihong@...edance.com,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
 santosh.shukla@....com, ananth.narayan@....com, sandipan.das@....com,
 Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [RFC 0/4] perf sched: Introduce schedstat tool

>> TODO:
>>  - This RFC series supports v15 layout of /proc/schedstat but v16 layout
>>    is already being pushed upstream. We are planning to include v16 as
>>    well in the next revision.
>>  - Currently schedstat tool provides statistics of only one run but we
>>    are planning to add `perf sched schedstat diff` which can compare
>>    the data of two different runs (possibly good and bad) and highlight
>>    where scheduler decisions are impacting workload performance.
>>  - perf sched schedstat records /proc/schedstat which is a cpu and domain
>>    level scheduler statistic. We are planning to add taskstat tool which
>>    reads task stats from procfs and generate scheduler statistic report
>>    at task granularity. this will probably a standalone tool, something
>>    like `perf sched taskstat record/report`.
>>  - /proc/schedstat shows cpumask in domain line to indicate a group of
>>    cpus that belong to the domain. Since we are not using domain<->cpumask
>>    data anywhere, we are not capturing it as part of perf sample. But we
>>    are planning to include it in the next revision.
>>  - We have tested the patch only on AMD machines, not on other platforms.
> 
> This is great! Is it possible to add some basic shell script testing:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/shell?h=perf-tools-next
> for the sake of coverage, other platform testing, etc. ?

Sure, I will think about adding some simple tests.

Thanks,
Ravi