linux-kernel - [PATCH v2 0/2] Selftests: Fix compilation warnings due to missing _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu,  9 May 2024 13:31:11 +0800
From: Tao Su <tao1.su@...ux.intel.com>
To: linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org,
	kvm@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-rtc@...r.kernel.org,
	linux-sgx@...r.kernel.org
Cc: akpm@...ux-foundation.org,
	edliaw@...gle.com,
	ivan.orlov0322@...il.com,
	broonie@...nel.org,
	perex@...ex.cz,
	tiwai@...e.com,
	shuah@...nel.org,
	seanjc@...gle.com,
	pbonzini@...hat.com,
	bongsu.jeon@...sung.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	alexandre.belloni@...tlin.com,
	jarkko@...nel.org,
	dave.hansen@...ux.intel.com,
	tao1.su@...ux.intel.com
Subject: [PATCH v2 0/2] Selftests: Fix compilation warnings due to missing _GNU_SOURCE definition

Since kselftest_harness.h introduces asprintf()[1], many selftests have
compilation warnings or errors due to missing _GNU_SOURCE definitions.

The issue stems from a lack of a LINE_MAX definition in Android (see
commit 38c957f07038), which is the reason why asprintf() was introduced.
We tried adding _GNU_SOURCE definitions to more selftests to fix, but
asprintf() may continue to cause problems, and since it is quite late in
the 6.9 cycle, we would like to revert 809216233555 first to provide
testing for forks[2].

[1] https://lore.kernel.org/all/20240411231954.62156-1-edliaw@google.com
[2] https://lore.kernel.org/linux-kselftest/ZjuA3aY_iHkjP7bQ@google.com

v1 -> v2:
- Stop defining _GNU_SOURCE in related selftests
- Revert commit 809216233555
- Use 1024 in place of LINE_MAX to fix 38c957f07038

v1: https://lore.kernel.org/all/20240507063534.4191447-1-tao1.su@linux.intel.com/

Tao Su (2):
  Revert "selftests/harness: remove use of LINE_MAX"
  selftests/harness: Use 1024 in place of LINE_MAX

 tools/testing/selftests/kselftest_harness.h | 11 +++--------
 tools/testing/selftests/mm/mdwe_test.c      |  1 -
 2 files changed, 3 insertions(+), 9 deletions(-)


base-commit: 45db3ab70092637967967bfd8e6144017638563c
-- 
2.34.1