linux-kernel - Re: [PATCH v2 7/7] ARM: dts: samsung: exynos4212-tab3: Fix up wm1811 codec config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8c82b1a-db57-4e89-9beb-63992744afe6@kernel.org>
Date: Thu, 9 May 2024 09:13:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Alim Akhtar <alim.akhtar@...sung.com>, alsa-devel@...a-project.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 7/7] ARM: dts: samsung: exynos4212-tab3: Fix up wm1811
 codec config

On 08/05/2024 12:58, Artur Weber wrote:
> Drop incorrect interrupt parent and add MCLK2 clock.

1. Separate patches.
2. Missing explanation why. "Incorrect" says a bit, but not too much.
Also, imprecise - you remove all interrupts, not just incorrect parent.

Please provide proper rationale, why this is not correct and information
that bluetooth 32 kHz clock feeds both bluetooth module and audio codec.

> 

Best regards,
Krzysztof