linux-kernel - Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 9 May 2024 10:57:58 +0200
From: Johan Hovold <johan@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Johan Hovold <johan+linaro@...nel.org>, Lee Jones <lee@...nel.org>,
	Mark Brown <broonie@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Das Srinagesh <quic_gurus@...cinc.com>,
	Satya Priya <quic_c_skakit@...cinc.com>,
	Stephen Boyd <swboyd@...omium.org>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver

On Tue, May 07, 2024 at 08:14:43PM +0200, Krzysztof Kozlowski wrote:
> On 07/05/2024 19:22, Andy Shevchenko wrote:
> > On Tue, May 7, 2024 at 6:44 PM Johan Hovold <johan@...nel.org> wrote:
> >> On Mon, May 06, 2024 at 10:09:50PM +0300, Andy Shevchenko wrote:
> >>> Mon, May 06, 2024 at 05:08:29PM +0200, Johan Hovold kirjoitti:

> >>>> +MODULE_ALIAS("platform:qcom-pm8008-regulator");
> >>>
> >>> Use ID table instead.
> >>
> >> No, the driver is not using an id-table for matching so the alias is
> >> needed for module auto-loading.
> > 
> > Then create one. Added Krzysztof for that. (He is working on dropping
> > MODULE_ALIAS() in cases like this one)
> 
> Yeah, please use ID table, since this is a driver (unless I missed
> something). Module alias does not scale, leads to stale and duplicated
> entries, so should not be used as substitute of ID table. Alias is
> suitable for different cases.

There's no scalability issue here. If the driver uses driver name
matching then there will always be exactly one alias needed.

That said, we may use a platform device id table instead of matching on
parent compatible if subdrivers are going to be reused by multiple
devices. I'll consider that.

Johan