linux-kernel - Re: [PATCH v2 3/5] selftests: Include KHDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2b35876-db4d-4646-908f-1e7da1814d1c@nvidia.com>
Date: Wed, 8 May 2024 18:03:58 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Edward Liaw <edliaw@...gle.com>
CC: <shuah@...nel.org>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela
	<perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Catalin Marinas
	<catalin.marinas@....com>, Will Deacon <will@...nel.org>, Nhat Pham
	<nphamcs@...il.com>, Johannes Weiner <hannes@...xchg.org>, Christian Brauner
	<brauner@...nel.org>, Eric Biederman <ebiederm@...ssion.com>, Kees Cook
	<keescook@...omium.org>, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	"Thomas Gleixner" <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Peter
 Zijlstra <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>, André Almeida
	<andrealmeid@...lia.com>, Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires
	<bentiss@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>, Kevin Tian
	<kevin.tian@...el.com>, "Andy Lutomirski" <luto@...capital.net>, Will Drewry
	<wad@...omium.org>, "Marc Zyngier" <maz@...nel.org>, Oliver Upton
	<oliver.upton@...ux.dev>, James Morse <james.morse@....com>, Suzuki K Poulose
	<suzuki.poulose@....com>, Zenghui Yu <yuzenghui@...wei.com>, Paolo Bonzini
	<pbonzini@...hat.com>, "Sean Christopherson" <seanjc@...gle.com>, Anup Patel
	<anup@...infault.org>, "Atish Patra" <atishp@...shpatra.org>, Paul Walmsley
	<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Janosch Frank <frankja@...ux.ibm.com>, Claudio Imbrenda
	<imbrenda@...ux.ibm.com>, "David Hildenbrand" <david@...hat.com>,
	Mickaël Salaün <mic@...ikod.net>, Paul Moore
	<paul@...l-moore.com>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn"
	<serge@...lyn.com>, Andrew Morton <akpm@...ux-foundation.org>, Seth Forshee
	<sforshee@...nel.org>, Bongsu Jeon <bongsu.jeon@...sung.com>, "David S.
 Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Steffen Klassert
	<steffen.klassert@...unet.com>, "Herbert Xu" <herbert@...dor.apana.org.au>,
	Andreas Färber <afaerber@...e.de>, Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>, Matthieu Baerts <matttbe@...nel.org>, Mat
 Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, Willem
 de Bruijn <willemdebruijn.kernel@...il.com>, Fenghua Yu
	<fenghua.yu@...el.com>, Reinette Chatre <reinette.chatre@...el.com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, "Paul E. McKenney"
	<paulmck@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Jarkko Sakkinen <jarkko@...nel.org>, "Dave
 Hansen" <dave.hansen@...ux.intel.com>, Muhammad Usama Anjum
	<usama.anjum@...labora.com>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <kernel-team@...roid.com>,
	<linux-sound@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-mm@...ck.org>, <linux-input@...r.kernel.org>, <iommu@...ts.linux.dev>,
	<kvmarm@...ts.linux.dev>, <kvm@...r.kernel.org>,
	<kvm-riscv@...ts.infradead.org>, <linux-riscv@...ts.infradead.org>,
	<linux-security-module@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-actions@...ts.infradead.org>,
	<mptcp@...ts.linux.dev>, <linux-rtc@...r.kernel.org>,
	<linux-sgx@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile

On 5/8/24 5:29 PM, Edward Liaw wrote:
> On Wed, May 8, 2024 at 2:41 PM John Hubbard <jhubbard@...dia.com> wrote:
>> On 5/7/24 2:38 PM, Edward Liaw wrote:
..
>> Seeing as how these all include lib.mk, and all use CFLAGS, is there
>> any reason not to simply fix this in lib.mk instead? Like this:
>>
>> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
>> index 7fa4a96e26ed..df72610e0d2b 100644
>> --- a/tools/testing/selftests/lib.mk
>> +++ b/tools/testing/selftests/lib.mk
>> @@ -170,6 +170,8 @@ clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir)
>>    CFLAGS += $(USERCFLAGS)
>>    LDFLAGS += $(USERLDFLAGS)
>>
>> +CFLAGS += $(KHDR_INCLUDES)
>> +
>>    # When make O= with kselftest target from main level
>>    # the following aren't defined.
>>    #
>>
> 
> Or how about just adding -D_GNU_SOURCE to CFLAGS then?

Yes, that would also work. I think either one would be good.


thanks,
-- 
John Hubbard
NVIDIA