linux-kernel - Re: [PATCH v2 net 1/2] net: dsa: mv88e6xxx: add phylink_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 09 May 2024 11:52:38 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Steffen Bätz <steffen@...osonix.de>
Cc: Andrew Lunn <andrew@...n.ch>, Fabio Estevam <festevam@...il.com>, 
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Russell King
 <linux@...linux.org.uk>,  "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 1/2] net: dsa: mv88e6xxx: add phylink_get_caps
 for the mv88e6320/21 family

On Wed, 2024-05-08 at 09:29 +0200, Steffen Bätz wrote:
> As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to
> be filled")
> Marvell 88e6320/21 switches fail to be probed:
> 
> ...
> mv88e6085 30be0000.ethernet-1:00: phylink: error: empty supported_interfaces
> error creating PHYLINK: -22
> ...
> 
> The problem stems from the use of mv88e6185_phylink_get_caps() to get
> the device capabilities. 
> Since there are serdes only ports 0/1 included, create a new dedicated 
> phylink_get_caps for the 6320 and 6321 to properly support their 
> set of capabilities.
> 
> Fixes: de5c9bf40c45 ("net: phylink: require supported_interfaces to be filled")
> 
> Signed-off-by: Steffen Bätz <steffen@...osonix.de>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Fabio Estevam <festevam@...il.com>
> 
> Changes since v1:
> - Removed unused variables.
> - Collected Reviewed-by tags from Andrew and Fabio

The changelog should come after a '---' separator, so it will not be
included into the commit message, and you must avoid the empty line
after the fixes tag.

I made the above changes while applying the patch, but this is really
an exception, please take care for the next submissions.

Cheers,

Paolo