| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c721f2b9-2b08-45f3-adb5-09b163924fbc@collabora.com> Date: Thu, 9 May 2024 17:43:42 +0200 From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> To: Nícolas F. R. A. Prado <nfraprado@...labora.com>, Hsin-Te Yuan <yuanhsinte@...omium.org> Cc: Sebastian Reichel <sre@...nel.org>, kernel@...labora.com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, Pin-yen Lin <treapking@...omium.org> Subject: Re: [PATCH v3] power: supply: sbs-battery: Handle unsupported PROP_TIME_TO_EMPTY_NOW Il 09/05/24 17:25, Nícolas F. R. A. Prado ha scritto: > On Mon, Apr 22, 2024 at 04:10:23PM +0800, Hsin-Te Yuan wrote: >> On Sat, Apr 20, 2024 at 12:03 AM Nícolas F. R. A. Prado >> <nfraprado@...labora.com> wrote: >>> >>> On Thu, Apr 18, 2024 at 01:34:23PM -0400, Nícolas F. R. A. Prado wrote: >>>> Despite the RunTimeToEmpty() (0x11) function being defined in the SBS >>>> specification as required, it seems that not all batteries implement it. >>>> On platforms with such batteries, reading the property will cause an >>>> error to be printed: >>>> >>>> power_supply sbs-8-000b: driver failed to report `time_to_empty_now' property: -5 >>>> >>>> This not only pollutes the log, distracting from real problems on the >>>> device, but also prevents the uevent file from being read since it >>>> contains all properties, including the faulty one. >>>> >>>> The following table summarizes the findings for a handful of platforms: >>>> >>>> Platform Status Manufacturer Model >>>> ------------------------------------------------------------------------ >>>> mt8186-corsola-steelix-sku131072 OK BYD L22B3PG0 >>>> mt8195-cherry-tomato-r2 NOT OK PANASON AP16L5J >>>> mt8192-asurada-spherion-r0 NOT OK PANASON AP15O5L >>>> mt8183-kukui-jacuzzi-juniper-sku16 NOT OK LGC KT0 AP16L8J >>>> mt8173-elm-hana OK Sunwoda L18D3PG1 >>>> sc7180-trogdor-lazor-limozeen-nots-r5 NOT OK Murata AP18C4K >>>> sc7180-trogdor-kingoftown NOT OK 333-AC-0D-A GG02047XL >>>> rk3399-gru-kevin OK SDI 4352D51 >>>> >>>> Detect if this is one of the quirky batteries during presence update, so >>>> that hot-plugging works as expected, and if so report -ENODATA for >>>> POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, which removes it from uevent and >>>> prevents throwing errors. >>>> >>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com> >>>> --- >>> >>> Hi, >>> >>> I'm coming back with more information after some more testing has been done. >>> >>> Most importantly, in the meantime, a parallel investigation uncovered that the >>> time_to_empty_now issue was actually in the EC firmware: >>> https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5465747 >>> >>> So the other faulty properties (which I'll mention below) could also be due to >>> the EC firmware. These are the EC firmware version for the platforms with >>> additional issues: >>> * RW version: juniper_v2.0.2509-9101a0730 >>> * RW version: lazor_v2.0.6519-9923041f79 >>> >>> Hsin-Te, do you have information on whether it's an EC issue in this case as >>> well? >>> >>> The following table shows all the faulty properties per platform: >>> >>> Platform Manufacturer Model Faulty properties >>> --------------------------------------------------------------------------------- >>> mt8186-corsola-steelix-sku131072 BYD L22B3PG0 - >>> mt8195-cherry-tomato-r2 PANASON AP16L5J time_to_empty_now >>> mt8192-asurada-spherion-r0 PANASON AP15O5L time_to_empty_now >>> mt8183-kukui-jacuzzi-juniper-sku16 LGC KT0 AP16L8J time_to_empty_now >>> capacity_error_margin >>> constant_charge_current_max >>> constant_charge_voltage_max >>> current_avg >>> technology >>> manufacture_year >>> manufacture_month >>> manufacture_day >>> SPEC_INFO >>> mt8173-elm-hana Sunwoda L18D3PG1 - >>> sc7180-trogdor-lazor-limozeen-nots-r5 Murata AP18C4K time_to_empty_now >>> capacity_error_margin >>> constant_charge_current_max >>> constant_charge_voltage_max >>> current_avg >>> sc7180-trogdor-kingoftown 333-AC-0D-A GG02047XL time_to_empty_now >>> rk3399-gru-kevin SDI 4352D51 - >>> > [..] >> >> It looks like the firmware version of juniper is too old. Could you >> update the firmware and test it again? >> Also, Could you provide the error you get from lazor? > > Getting back on this, we were finally able to update the EC firmware for both > juniper and limozeen and all the issues were fixed. I have added the logs below > just for reference. So I guess the only change we could have upstream would be a > message suggesting the user to update the EC firmware in case the SBS is behind > the CrosEC and it starts throwing errors. I'll prepare a patch for that. > ..yes, but then you can't do that in the sbs-battery driver, but rather in the CrOS EC - so you'd have to link this and the other driver (beware: I'm not proposing to do that!), which wouldn't be the cleanest of options. Perhaps we could check "how many times *in a row, from boot*" the readout is failing and dynamically add the quirk with a big pr_warn(). I guess that could work but, at the same time, that's code to engineer very carefully, or we'd risk breaking machines that would get that reading to work, for example, only after a suspend-resume cycle (which is bad, yes, but still) or other oddities... Any other ideas? Cheers, Angelo > Thanks, > Nícolas > > limozeen: > + cat /sys/class/power_supply/sbs-12-000b/time_to_empty_now > 3932100 > + cat /sys/class/power_supply/sbs-12-000b/capacity_error_margin > 3 > + cat /sys/class/power_supply/sbs-12-000b/constant_charge_current_max > 0 > + cat /sys/class/power_supply/sbs-12-000b/constant_charge_voltage_max > 0 > + cat /sys/class/power_supply/sbs-12-000b/current_avg > 0 > + cat /sys/class/power_supply/sbs-12-000b/uevent > DEVTYPE=power_supply > OF_NAME=sbs-battery > OF_FULLNAME=/soc@...eniqup@...000/spi@...000/ec@...2c-tunnel/sbs-battery@b > OF_COMPATIBLE_0=sbs,sbs-battery > OF_COMPATIBLE_N=1 > POWER_SUPPLY_NAME=sbs-12-000b > POWER_SUPPLY_TYPE=Battery > POWER_SUPPLY_STATUS=Full > POWER_SUPPLY_CAPACITY_LEVEL=Full > POWER_SUPPLY_HEALTH=Unknown > POWER_SUPPLY_PRESENT=1 > POWER_SUPPLY_TECHNOLOGY=Li-poly > POWER_SUPPLY_CYCLE_COUNT=2 > POWER_SUPPLY_VOLTAGE_NOW=12293000 > POWER_SUPPLY_CURRENT_NOW=0 > POWER_SUPPLY_CURRENT_AVG=0 > POWER_SUPPLY_CAPACITY=97 > POWER_SUPPLY_CAPACITY_ERROR_MARGIN=3 > POWER_SUPPLY_TEMP=194 > POWER_SUPPLY_TIME_TO_EMPTY_NOW=3932100 > POWER_SUPPLY_TIME_TO_EMPTY_AVG=3932100 > POWER_SUPPLY_TIME_TO_FULL_AVG=3932100 > POWER_SUPPLY_SERIAL_NUMBER=023e > POWER_SUPPLY_VOLTAGE_MIN_DESIGN=11400000 > POWER_SUPPLY_VOLTAGE_MAX_DESIGN=11400000 > POWER_SUPPLY_ENERGY_NOW=42420000 > POWER_SUPPLY_ENERGY_FULL=43700000 > POWER_SUPPLY_ENERGY_FULL_DESIGN=51630000 > POWER_SUPPLY_CHARGE_NOW=3451000 > POWER_SUPPLY_CHARGE_FULL=3555000 > POWER_SUPPLY_CHARGE_FULL_DESIGN=4200000 > POWER_SUPPLY_CONSTANT_CHARGE_CURRENT_MAX=0 > POWER_SUPPLY_CONSTANT_CHARGE_VOLTAGE_MAX=0 > POWER_SUPPLY_MANUFACTURE_YEAR=2021 > POWER_SUPPLY_MANUFACTURE_MONTH=3 > POWER_SUPPLY_MANUFACTURE_DAY=14 > POWER_SUPPLY_MANUFACTURER=Murata KT00304012 > POWER_SUPPLY_MODEL_NAME=AP18C4K > + cat /sys/class/chromeos/cros_ec/version > RO version: lazor_v2.0.23149-099cd3e539 > RW version: lazor_v2.0.23149-099cd3e539 > > juniper: > + cat /sys/class/power_supply/sbs-12-000b/time_to_empty_now > 3932100 > + cat /sys/class/power_supply/sbs-12-000b/capacity_error_margin > 3 > + cat /sys/class/power_supply/sbs-12-000b/constant_charge_current_max > 0 > + cat /sys/class/power_supply/sbs-12-000b/constant_charge_voltage_max > 0 > + cat /sys/class/power_supply/sbs-12-000b/current_avg > 0 > + cat /sys/class/power_supply/sbs-12-000b/technology > Li-ion > + cat /sys/class/power_supply/sbs-12-000b/manufacture_year > 2020 > + cat /sys/class/power_supply/sbs-12-000b/manufacture_month > 10 > + cat /sys/class/power_supply/sbs-12-000b/manufacture_day > 7 > + cat /sys/class/power_supply/sbs-12-000b/uevent > DEVTYPE=power_supply > OF_NAME=sbs-battery > OF_FULLNAME=/soc/spi@...12000/cros-ec@...2c-tunnel/sbs-battery@b > OF_COMPATIBLE_0=sbs,sbs-battery > OF_COMPATIBLE_N=1 > POWER_SUPPLY_NAME=sbs-12-000b > POWER_SUPPLY_TYPE=Battery > POWER_SUPPLY_STATUS=Full > POWER_SUPPLY_CAPACITY_LEVEL=Full > POWER_SUPPLY_HEALTH=Unknown > POWER_SUPPLY_PRESENT=1 > POWER_SUPPLY_TECHNOLOGY=Li-ion > POWER_SUPPLY_CYCLE_COUNT=8 > POWER_SUPPLY_VOLTAGE_NOW=8210000 > POWER_SUPPLY_CURRENT_NOW=0 > POWER_SUPPLY_CURRENT_AVG=0 > POWER_SUPPLY_CAPACITY=99 > POWER_SUPPLY_CAPACITY_ERROR_MARGIN=3 > POWER_SUPPLY_TEMP=215 > POWER_SUPPLY_TIME_TO_EMPTY_NOW=3932100 > POWER_SUPPLY_TIME_TO_EMPTY_AVG=3932100 > POWER_SUPPLY_TIME_TO_FULL_AVG=3932100 > POWER_SUPPLY_SERIAL_NUMBER=26c9 > POWER_SUPPLY_VOLTAGE_MIN_DESIGN=7500000 > POWER_SUPPLY_VOLTAGE_MAX_DESIGN=7500000 > POWER_SUPPLY_ENERGY_NOW=34990000 > POWER_SUPPLY_ENERGY_FULL=35170000 > POWER_SUPPLY_ENERGY_FULL_DESIGN=39940000 > POWER_SUPPLY_CHARGE_NOW=4262000 > POWER_SUPPLY_CHARGE_FULL=4284000 > POWER_SUPPLY_CHARGE_FULL_DESIGN=4865000 > POWER_SUPPLY_CONSTANT_CHARGE_CURRENT_MAX=0 > POWER_SUPPLY_CONSTANT_CHARGE_VOLTAGE_MAX=0 > POWER_SUPPLY_MANUFACTURE_YEAR=2020 > POWER_SUPPLY_MANUFACTURE_MONTH=10 > POWER_SUPPLY_MANUFACTURE_DAY=7 > POWER_SUPPLY_MANUFACTURER=LGC KT0 > POWER_SUPPLY_MODEL_NAME=AP16L8J > + cat /sys/class/chromeos/cros_ec/version > RO version: juniper_v2.0.2796-7246101293 > RW version: juniper_v2.0.2796-7246101293 > _______________________________________________
Powered by blists - more mailing lists