linux-kernel - Re: [PATCH] drm/radeon: Delay Connector detecting when HPD singals is unstable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 9 May 2024 13:24:03 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: oushixiong <oushixiong@...inos.cn>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Xinhui.Pan@....com
Subject: Re: [PATCH] drm/radeon: Delay Connector detecting when HPD singals is unstable

On Thu, May 9, 2024 at 4:58 AM oushixiong <oushixiong@...inos.cn> wrote:
>
> From: Shixiong Ou <oushixiong@...inos.cn>
>
> In some causes, HPD signals will jitter when plugging in
> or unplugging HDMI.
>
> Rescheduling the hotplug work for a second when EDID may still be
> readable but HDP is disconnected, and fixes this issue.
>
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_connectors.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index b84b58926106..cf0114ca59a4 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1267,6 +1267,16 @@ radeon_dvi_detect(struct drm_connector *connector, bool force)
>                         goto exit;
>                 }
>         }
> +
> +       if (dret && radeon_connector->hpd.hpd != RADEON_HPD_NONE &&
> +           !radeon_hpd_sense(rdev, radeon_connector->hpd.hpd) &&
> +           connector->connector_type == DRM_MODE_CONNECTOR_HDMIA) {
> +               DRM_DEBUG_KMS("EDID is readable when HPD disconnected\n");
> +               schedule_delayed_work(&rdev->hotplug_work, msecs_to_jiffies(1000));
> +               ret = connector_status_disconnected;
> +               goto exit;
> +       }
> +
>         if (dret) {
>                 radeon_connector->detected_by_load = false;
>                 radeon_connector_free_edid(connector);
> --
> 2.17.1
>