linux-kernel - Re: [External] : [PATCH 1/2] tcp: fix get_tcp4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 9 May 2024 21:46:54 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: David Wei <dw@...idwei.uk>
Cc: Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@...cle.com>, Yuan Fang <yf768672249@...il.com>, 
	"davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [External] : [PATCH 1/2] tcp: fix get_tcp4_sock() output error info

On Thu, May 9, 2024 at 8:09 PM David Wei <dw@...idwei.uk> wrote:
>
> On 2024-05-09 10:29, Mohith Kumar Thummaluru wrote:
> > Good catch! Thanks for this fix.
>
> If this is a fix, can you please add a Fixes tag? And in general some
> surrounding context in a cover letter? Thanks.

I do not think it is a fix, and I am not sure we want this patch anyway.

/proc interface is legacy, we do not change it.

Please use TCP_INFO or inet_diag, because
commit 5ee3afba88f5 "[TCP]: Return useful listenq info in tcp_info and
INET_DIAG_INFO."
took care of this in 2007.

Already in 2007 we were considering /proc/net/tcp as a legacy.