linux-kernel - Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARZu1Jrqibn-PvjAa=dQwikMdWVH9d9oKwpe007JeVC6Q@mail.gmail.com>
Date: Thu, 9 May 2024 11:05:31 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Doug Anderson <dianders@...omium.org>
Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>, freedreno@...ts.freedesktop.org, 
	Rob Clark <robdclark@...il.com>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Sean Paul <sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, 
	seanpaul@...omium.org, swboyd@...omium.org, quic_jesszhan@...cinc.com, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

On Thu, May 9, 2024 at 9:28 AM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar <quic_abhinavk@...cinccom> wrote:
> >
> > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"),
> > compilation is broken on machines having python versions older than 3.9
> > due to dependency on argparse.BooleanOptionalAction.
> >
> > Switch to use simple bool for the validate flag to remove the dependency.
> >
> > Fixes: 5acf49119630 ("drm/msm: import gen_header.py script from Mesa")
> > Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> > ---
> >  drivers/gpu/drm/msm/registers/gen_header.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
>
> No idea if we're supposed to allow python as a build dependency. That
> being said, I can confirm that this fixes the problem for me since I
> ran into it too [1].
>
> Tested-by: Douglas Anderson <dianders@...omium.org>
>
> [1] https://lore.kernel.org/r/CAD=FV=XnpS-=CookKxzFM8og9WCSEMxfESmfTYH811438qg4ng@mail.gmail.com
>


I do not like Perl.

IMHO, Python should be OK if Perl is OK.
I agree that the required version should be
documented changes.rst, at least.






-- 
Best Regards
Masahiro Yamada